From ade7b1f7c7f70f1156ca667661085b40ee12e276 Mon Sep 17 00:00:00 2001 From: Marco Pivetta Date: Sun, 14 Dec 2014 06:04:18 +0100 Subject: [PATCH] #167 - Remove code specifically designed to skip tests in PHP <= 5.4.1 --- ...cessInterceptorScopeLocalizerFunctionalTest.php | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tests/ProxyManagerTest/Functional/AccessInterceptorScopeLocalizerFunctionalTest.php b/tests/ProxyManagerTest/Functional/AccessInterceptorScopeLocalizerFunctionalTest.php index d44d5a49f..e5fb5afbf 100644 --- a/tests/ProxyManagerTest/Functional/AccessInterceptorScopeLocalizerFunctionalTest.php +++ b/tests/ProxyManagerTest/Functional/AccessInterceptorScopeLocalizerFunctionalTest.php @@ -324,7 +324,7 @@ public function getProxyMethods() { $selfHintParam = new ClassWithSelfHint(); - $data = [ + return [ [ BaseClass::class, new BaseClass(), @@ -346,20 +346,14 @@ public function getProxyMethods() [], 'publicByReferenceMethodDefault' ], - ]; - - if (PHP_VERSION_ID >= 50401) { - // PHP < 5.4.1 misbehaves, throwing strict standards, see https://bugs.php.net/bug.php?id=60573 - $data[] = [ + [ ClassWithSelfHint::class, new ClassWithSelfHint(), 'selfHintMethod', ['parameter' => $selfHintParam], $selfHintParam - ]; - } - - return $data; + ], + ]; } /**