-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to angular 6.0.1 and Rxjs 6.1.0 #135
Migrate to angular 6.0.1 and Rxjs 6.1.0 #135
Conversation
Travis build failed due to a strange timeout while fetching some dependencies. Nice PR 👍 I was about to do the same as removing rxjs-compat is a top priority for a lot of people right now (including me). |
@Supamiu Thanks! Should I do anything concerning the Travis build or should I wait for anyone to restart it if possible ? |
I think @ObaidUrRehman should restart the build, or test the build by him/herself, just to make sure everything is going fine. |
@arnaudleclerc, Thanks for this PR. |
@arnaudleclerc, any idea why I get this error when running the demo app:
Guess its time to upgarde demo app to use angular cli. |
@ObaidUrRehman I managed to start the demo app without the angular-cli. I'll take a look at it and let you know. Thanks for the merge! |
@ObaidUrRehman I started your demo application yesterday and didn't have any problem so far. I'll assume then that you're trying to run it with the v4 of your package. If so, your demo-app needs to have a dependency to rxjs-compat to continue working correctly. The mapping to the old rxjs/Observable and other old paths will be handled by this package. That's for the combination angular v6 + ng-drag-drop v4. If you publish the next version of your package, this rxjs-compat will be useless and can be removed (which was the goal of this PR). For you to try, build your package and copy the javascript files of the two directives and the ng-drag-drop.service into the node_modules of your demo app (which is the same thing as installing the v6 of your package) and it should run smooth. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Migration to angular 6.0.1 and Rxjs 6.1.0
What is the current behavior? (You can also link to an open issue here)
#132