New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow draghandle to work for touchscreens when used with polyfill #112

Merged

ObaidUrRehman merged 1 commit into ObaidUrRehman:master from andreialecu:fix-touch

Jan 1, 2018

Contributor

andreialecu commented Dec 30, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

I've been able to use this polyfill to enable drag and drop for touch devices:
https://github.com/timruffles/ios-html5-drag-drop-shim

However, when using .drag-handle, there is an Illegal invocation error because the drag handle isn't registered properly on touch screens.

What is the new behavior (if this is a feature change)?

Allows the drag handle to be registered properly on a touch start event.


          feat: allow draghandle to work for touchscreens when used with polyfill

a3bb715

andreialecu mentioned this pull request

Touch enabled #47

Open

ObaidUrRehman approved these changes

View reviewed changes

Owner

ObaidUrRehman commented Jan 1, 2018

Thanks @andreialecu . I will publish a new build asap.

ObaidUrRehman merged commit 0d3ba55 into ObaidUrRehman:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet