Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async dropScope function #97

Closed
akagr opened this issue Sep 26, 2017 · 3 comments
Closed

Add support for async dropScope function #97

akagr opened this issue Sep 26, 2017 · 3 comments
Assignees

Comments

@akagr
Copy link
Contributor

akagr commented Sep 26, 2017

  • I'm submitting a ...
    [ ] bug report
    [x] feature request
    [ ] other

  • What is the current behavior?
    Right now, the dropScope has to be defined synchronously. If it's a function, it has to return true or false.

  • What is the expected behavior?
    I propose we allow the dropScope to be set to a function that returns an observable. That observable may then resolve to true or false. This would allow for scenarios, where say, we need to check with backend if the drop is allowed via http calls.

I'm willing to give developing this a try myself and PR it if it sounds good.

@ObaidUrRehman
Copy link
Owner

@akagr LGTM, the dropScope is already defined as string | Array<string> | Function so adding an Observable shouldn't be an issue.

Looking forward to your PR.
👍

@akagr
Copy link
Contributor Author

akagr commented Oct 5, 2017

@ObaidUrRehman Great thanks! Will try to get to it this weekend 😄

@ObaidUrRehman
Copy link
Owner

Added in v3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants