Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pagination to display projects instead of repositories #3253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Jan 22, 2025

Closes: #3250

Copy link

sentry-io bot commented Jan 22, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views/project.py

Function Unhandled Issue
get_context_data AttributeError: 'ProjectListView' object has no attribute 'object_list' ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 22, 2025

@DonnieBLT sir, can you please review the changes? I cannot populate local db with project details so I couldn't test the changes locally. If possible, can you please test the changes?
thanks a ton!

@tsu-ki tsu-ki marked this pull request as ready for review January 24, 2025 10:59
@tsu-ki
Copy link
Contributor Author

tsu-ki commented Jan 24, 2025

@DonnieBLT sir, just wanted to confirm if the changes have been tested before getting approved. Please do confirm this, thank you!

@DonnieBLT
Copy link
Collaborator

I have not tested it, let me know when it’s ready. Thank you 🙏

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Feb 5, 2025

@DonnieBLT sir, this PR is ready to be reviewed. thank you!
(results are getting filtered on basis of projects and not repositories)

Screenshot 2025-02-05 at 7 55 51 PM

@tsu-ki tsu-ki requested a review from DonnieBLT February 5, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make the projects page show 10 projects per page and fix the count on the filter stat
2 participants