From 0ea5e37d4122cf9df540a324f74ad55836e27d1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Edouard=20Choini=C3=A8re?=
 <27212526+echoix@users.noreply.github.com>
Date: Sat, 28 Sep 2024 17:58:09 -0400
Subject: [PATCH] style: Fix reimplemented-operator (FURB118) (#4408)

* style: Fix reimplemented-operator (FURB118)

Ruff rule: https://docs.astral.sh/ruff/rules/reimplemented-operator/

Replaced lambdas with `operator.itemgetter()` or `operator.add()`. These are implemented more efficiently in C and have a Python fallback.

* utils/g.html2man: Replace children function with operator.itemgetter
---
 gui/wxpython/animation/temporal_manager.py   |  5 +++--
 gui/wxpython/gui_core/ghelp.py               |  3 ++-
 gui/wxpython/mapwin/buffered.py              | 10 ++++++----
 gui/wxpython/psmap/dialogs.py                |  7 +++----
 gui/wxpython/timeline/frame.py               |  5 ++---
 gui/wxpython/tplot/frame.py                  |  5 ++---
 man/build_full_index.py                      |  4 +++-
 pyproject.toml                               |  1 -
 python/grass/imaging/images2ims.py           |  3 ++-
 scripts/g.search.modules/g.search.modules.py |  4 +++-
 scripts/v.report/v.report.py                 |  4 +++-
 utils/g.html2man/rest.py                     |  4 ++--
 12 files changed, 31 insertions(+), 24 deletions(-)

diff --git a/gui/wxpython/animation/temporal_manager.py b/gui/wxpython/animation/temporal_manager.py
index 150eeab510f..ef782543089 100644
--- a/gui/wxpython/animation/temporal_manager.py
+++ b/gui/wxpython/animation/temporal_manager.py
@@ -18,6 +18,7 @@
 """
 
 import datetime
+from operator import itemgetter
 
 import grass.script as gs
 import grass.temporal as tgis
@@ -195,9 +196,9 @@ def GetLabelsAndMaps(self):
         # by a temporary dataset, I don't know how it would work with point
         # data
         if self.temporalType == TemporalType.ABSOLUTE:
-            timestamps = sorted(list(labelListSet), key=lambda x: x[0])
+            timestamps = sorted(list(labelListSet), key=itemgetter(0))
         else:
-            timestamps = sorted(list(labelListSet), key=lambda x: x[0])
+            timestamps = sorted(list(labelListSet), key=itemgetter(0))
 
         newMapLists = []
         for mapList, labelList in zip(mapLists, labelLists):
diff --git a/gui/wxpython/gui_core/ghelp.py b/gui/wxpython/gui_core/ghelp.py
index 93879998133..72e2564b74d 100644
--- a/gui/wxpython/gui_core/ghelp.py
+++ b/gui/wxpython/gui_core/ghelp.py
@@ -25,6 +25,7 @@
 import sys
 import wx
 from wx.html import HtmlWindow
+from operator import itemgetter
 
 try:
     from wx.lib.agw.hyperlink import HyperLinkCtrl
@@ -450,7 +451,7 @@ def _pageContributors(self, extra=False):
                 text = StaticText(parent=contribwin, id=wx.ID_ANY, label=item)
                 text.SetFont(wx.Font(10, wx.DEFAULT, wx.NORMAL, wx.BOLD, 0, ""))
                 contribBox.Add(text)
-            for vals in sorted(contribs, key=lambda x: x[0]):
+            for vals in sorted(contribs, key=itemgetter(0)):
                 for item in vals:
                     contribBox.Add(
                         StaticText(parent=contribwin, id=wx.ID_ANY, label=item)
diff --git a/gui/wxpython/mapwin/buffered.py b/gui/wxpython/mapwin/buffered.py
index e0442ed94ae..d8c6413017b 100644
--- a/gui/wxpython/mapwin/buffered.py
+++ b/gui/wxpython/mapwin/buffered.py
@@ -28,6 +28,8 @@
 
 import wx
 
+from operator import itemgetter
+
 from grass.pydispatch.signal import Signal
 
 from core.globalvar import wxPythonPhoenix
@@ -462,10 +464,10 @@ def Draw(
                     brush = wx.TRANSPARENT_BRUSH
                 pdc.SetBrush(brush)
                 pdc.DrawPolygon(points=coords)
-                x = min(coords, key=lambda x: x[0])[0]
-                y = min(coords, key=lambda x: x[1])[1]
-                w = max(coords, key=lambda x: x[0])[0] - x
-                h = max(coords, key=lambda x: x[1])[1] - y
+                x = min(coords, key=itemgetter(0))[0]
+                y = min(coords, key=itemgetter(1))[1]
+                w = max(coords, key=itemgetter(0))[0] - x
+                h = max(coords, key=itemgetter(1))[1] - y
                 pdc.SetIdBounds(drawid, Rect(x, y, w, h))
 
         elif pdctype == "circle":  # draw circle
diff --git a/gui/wxpython/psmap/dialogs.py b/gui/wxpython/psmap/dialogs.py
index 4eea798f731..41493795893 100644
--- a/gui/wxpython/psmap/dialogs.py
+++ b/gui/wxpython/psmap/dialogs.py
@@ -37,6 +37,7 @@
 import os
 import string
 from copy import deepcopy
+from operator import itemgetter
 from pathlib import Path
 
 import wx
@@ -3623,9 +3624,7 @@ def _vectorLegend(self, notebook):
         self.vectorListCtrl.InsertColumn(0, _("Vector map"))
         self.vectorListCtrl.InsertColumn(1, _("Label"))
         if self.vectorId:
-            vectors = sorted(
-                self.instruction[self.vectorId]["list"], key=lambda x: x[3]
-            )
+            vectors = sorted(self.instruction[self.vectorId]["list"], key=itemgetter(3))
 
             for vector in vectors:
                 index = self.vectorListCtrl.InsertItem(
@@ -4456,7 +4455,7 @@ def updateDialog(self):
         if self.instruction.FindInstructionByType("vector"):
             vectors = sorted(
                 self.instruction.FindInstructionByType("vector")["list"],
-                key=lambda x: x[3],
+                key=itemgetter(3),
             )
             self.vectorListCtrl.DeleteAllItems()
             for vector in vectors:
diff --git a/gui/wxpython/timeline/frame.py b/gui/wxpython/timeline/frame.py
index 3982034619c..9a783f4f5d5 100644
--- a/gui/wxpython/timeline/frame.py
+++ b/gui/wxpython/timeline/frame.py
@@ -22,6 +22,7 @@
 
 import wx
 from functools import reduce
+from operator import add
 
 try:
     import matplotlib as mpl
@@ -495,9 +496,7 @@ def _checkDatasets(self, datasets):
         ]
         # flatten this list
         if allDatasets:
-            allDatasets = reduce(
-                lambda x, y: x + y, reduce(lambda x, y: x + y, allDatasets)
-            )
+            allDatasets = reduce(add, reduce(add, allDatasets))
             mapsets = tgis.get_tgis_c_library_interface().available_mapsets()
             allDatasets = [
                 i
diff --git a/gui/wxpython/tplot/frame.py b/gui/wxpython/tplot/frame.py
index 2c7d49c3d72..8994485dacc 100755
--- a/gui/wxpython/tplot/frame.py
+++ b/gui/wxpython/tplot/frame.py
@@ -69,6 +69,7 @@
 
 from gui_core.widgets import GNotebook
 from gui_core.wrap import CheckBox, TextCtrl, Button, StaticText
+from operator import add
 
 ALPHA = 0.5
 COLORS = ["b", "g", "r", "c", "m", "y", "k"]
@@ -1153,9 +1154,7 @@ def _checkDatasets(self, datasets, typ):
         ]
         # flatten this list
         if allDatasets:
-            allDatasets = reduce(
-                lambda x, y: x + y, reduce(lambda x, y: x + y, allDatasets)
-            )
+            allDatasets = reduce(add, reduce(add, allDatasets))
             mapsets = tgis.get_tgis_c_library_interface().available_mapsets()
             allDatasets = [
                 i
diff --git a/man/build_full_index.py b/man/build_full_index.py
index ead5167cbb1..7d2ce03e342 100644
--- a/man/build_full_index.py
+++ b/man/build_full_index.py
@@ -9,6 +9,8 @@
 import sys
 import os
 
+from operator import itemgetter
+
 from build_html import (
     html_dir,
     grass_version,
@@ -50,7 +52,7 @@
     prefix = cmd.split(".")[0]
     if prefix not in [item[0] for item in classes]:
         classes.append((prefix, class_labels.get(prefix, prefix)))
-classes.sort(key=lambda tup: tup[0])
+classes.sort(key=itemgetter(0))
 
 # begin full index:
 filename = "full_index.html"
diff --git a/pyproject.toml b/pyproject.toml
index e288be23f10..3a6d449ec1d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -145,7 +145,6 @@ ignore = [
     "FBT001",  # boolean-type-hint-positional-argument
     "FBT002",  # boolean-default-value-positional-argument
     "FBT003",  # boolean-positional-value-in-call
-    "FURB118", # reimplemented-operator
     "I001",    # unsorted-imports
     "ISC003",  # explicit-string-concatenation
     "PERF203", # try-except-in-loop
diff --git a/python/grass/imaging/images2ims.py b/python/grass/imaging/images2ims.py
index 31088a22f2e..662e3eb46e0 100644
--- a/python/grass/imaging/images2ims.py
+++ b/python/grass/imaging/images2ims.py
@@ -31,6 +31,7 @@
 """
 
 import os
+from operator import itemgetter
 
 try:
     import numpy as np
@@ -214,7 +215,7 @@ def readIms(filename, asNumpy=True):
             images.append((im.copy(), nr))
 
     # Sort images
-    images.sort(key=lambda x: x[1])
+    images.sort(key=itemgetter(1))
     images = [im[0] for im in images]
 
     # Convert to numpy if needed
diff --git a/scripts/g.search.modules/g.search.modules.py b/scripts/g.search.modules/g.search.modules.py
index 85247517898..a3bab4325c2 100755
--- a/scripts/g.search.modules/g.search.modules.py
+++ b/scripts/g.search.modules/g.search.modules.py
@@ -66,6 +66,8 @@
 import os
 import sys
 
+from operator import itemgetter
+
 from grass.script import core as grass
 from grass.exceptions import CalledModuleError
 
@@ -283,7 +285,7 @@ def _search_module(
                 }
             )
 
-    return sorted(found_modules, key=lambda k: k["name"])
+    return sorted(found_modules, key=itemgetter("name"))
 
 
 def _basic_search(pattern, name, description, module_keywords) -> bool:
diff --git a/scripts/v.report/v.report.py b/scripts/v.report/v.report.py
index 18752a697cb..9da9a8b1de7 100755
--- a/scripts/v.report/v.report.py
+++ b/scripts/v.report/v.report.py
@@ -55,6 +55,8 @@
 
 import sys
 import os
+from operator import itemgetter
+
 import grass.script as gs
 from grass.script.utils import separator, decode
 
@@ -134,7 +136,7 @@ def main():
         if p.returncode != 0:
             sys.exit(1)
 
-        records1.sort(key=lambda r: r[catcol])
+        records1.sort(key=itemgetter(catcol))
 
         if len(records1) == 0:
             try:
diff --git a/utils/g.html2man/rest.py b/utils/g.html2man/rest.py
index 2df87db8e27..c320f18e397 100644
--- a/utils/g.html2man/rest.py
+++ b/utils/g.html2man/rest.py
@@ -1,4 +1,5 @@
 import sys
+from operator import itemgetter
 
 
 def match(node, tag, attr=None, val=None):
@@ -26,8 +27,7 @@ def find(node, tag, attr=None, val=None):
     raise ValueError("child not found")
 
 
-def children(node):
-    return node[2]
+children = itemgetter(2)
 
 
 def text(node):