Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misconfigured Custom Job Submission Example #939

Open
Oglopf opened this issue Feb 23, 2024 · 1 comment
Open

Misconfigured Custom Job Submission Example #939

Oglopf opened this issue Feb 23, 2024 · 1 comment

Comments

@Oglopf
Copy link
Contributor

Oglopf commented Feb 23, 2024

If you look at the example here:
https://osc.github.io/ood-documentation/latest/enable-desktops/custom-job-submission.html#custom-job-submission

It has the cluster attribute set while also providing a submit attribute as well. This is at best redundant and at worst very confusing to new users trying to use this setting. Yank the cluster attr and focus on the submit.

@johrstrom
Copy link
Contributor

I don't think I follow you on this. cluster and submit do very different things, so they're not redundant. I guess I'll have to look at the discourse topic that generated this, but if you look at all of our OSC production applications, we never override the cluster in the submit.yml.erb. It's something you can do for sure, but shouldn't be the default, it should be the exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants