Skip to content
This repository has been archived by the owner on Nov 13, 2019. It is now read-only.

Support specifying font awesome icons for apps #57

Closed
ericfranz opened this issue Oct 26, 2016 · 6 comments
Closed

Support specifying font awesome icons for apps #57

ericfranz opened this issue Oct 26, 2016 · 6 comments

Comments

@ericfranz
Copy link
Contributor

  1. OodApp#fa_icon can delegate to manifest#fa_icon
  2. manifests have a new field in yaml: fa_icon: gear
  3. default value in manifest is gear
  4. the logic of the dashboard will be that if icon.png is not present, use fa_icon instead
@ericfranz
Copy link
Contributor Author

This will let us use the manifest to specify all the icons for all the sys apps that we currently use.

@ericfranz
Copy link
Contributor Author

  • another alternative is in manifest instead of fa_icon: gear we do icon: fa-gear - could open up other options in future

@nickjer
Copy link
Contributor

nickjer commented Oct 26, 2016

Not a fan of adding fa_icon to manifest. I prefer your latter suggestion a "bit" more.

Unfortunately I can't think of a better option right now.

@ericfranz
Copy link
Contributor Author

okay, we will do:

  • manifest: icon: fa-gear
  • default is fa-gear
  • for now, assume only valid value for icon in manifest is a font-awesome class name - but later we can support other values - so OodApp#fa_icon can still be added (and we can change this later as necessary)

@nickjer
Copy link
Contributor

nickjer commented Oct 26, 2016

Maybe something like:

icon: file://./path/to/image.png
icon: fa://gear
icon: http://my.cdn.com/img.png

@ericfranz
Copy link
Contributor Author

icon: fa://gear

and only support fa://gear for now. If icon.png is in root, use that instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants