Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require DEFAULT_SSHHOST to be set in order for the ssh default URL to work #506

Closed
ericfranz opened this issue May 20, 2020 · 2 comments
Closed

Require DEFAULT_SSHHOST to be set in order for the ssh default URL to work #506

ericfranz opened this issue May 20, 2020 · 2 comments
Labels
component/shell
Milestone
OOD1.8

Comments

@ericfranz
Copy link
Contributor

ericfranz commented May 20, 2020 •
edited
Loading

Defaulting the default ssh host to localhost is a insecure default.

  1. Instead of defaulting to localhost, if DEFAULT_SSHHOST is not set, we should display an error explaining that DEFAULT_SSHHOST. (simplest straightforward solution)
@ericfranz ericfranz added this to the OOD1.8 milestone May 20, 2020
@github-actions github-actions bot modified the milestones: OOD1.8, Needs Triaged May 20, 2020
@ericfranz ericfranz modified the milestones: Needs Triaged, OOD1.8 May 20, 2020
@treydock
Copy link
Contributor

Why not use cluster configs? I feel like it's probably confusing for sites to have some things defined in cluster configs and other things defined in environment variables. I tend to lean towards centralized configs rather than configs in multiple places.

@matthu017
Copy link
Contributor

Duplicate of: #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/shell
Projects
None yet
Milestone
OOD1.8
Development

No branches or pull requests
3 participants
@ericfranz @treydock @matthu017