Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NavConfig #2255

Closed
johrstrom opened this issue Aug 19, 2022 · 2 comments · Fixed by #3475
Closed

Remove NavConfig #2255

johrstrom opened this issue Aug 19, 2022 · 2 comments · Fixed by #3475
Assignees
@HazelGrant
Labels
breaking change Upgrade Painpoint. Functionality Removal from previous version of software.
Milestone
4.0

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Aug 19, 2022 •
edited by sync-by-unito bot
Loading

With #2221 changing the behavior and then #2254 adding the warning. Let's then remove NavConfig altogether.

┆Issue is synchronized with this Asana task by Unito
@johrstrom johrstrom modified the milestones: 3.0, 2.0.28 Aug 19, 2022
@johrstrom johrstrom added the breaking change Upgrade Painpoint. Functionality Removal from previous version of software. label Jan 5, 2023
@HazelGrant HazelGrant self-assigned this Mar 28, 2024
@HazelGrant
Copy link
Contributor

What needs to happen with the use of NavConfig in UserConfiguration- specifically where it's referenced here:

https://github.com/OSC/ondemand/pull/2221/files#diff-8cbe6007d5dceb9e69860110358bae6e7d11cfa8791bc7c150a4c868ec9695efR108

@johrstrom
Copy link
Contributor Author

What needs to happen with the use of NavConfig in UserConfiguration- specifically where it's referenced here:

Something needs to hold/continue the defaults.

ondemand/apps/dashboard/app/apps/nav_config.rb

Line 6 in 7f32801

self.categories = ["Apps", "Files", "Jobs", "Clusters", "Interactive Apps"]

@HazelGrant HazelGrant mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HazelGrant HazelGrant

Labels
breaking change Upgrade Painpoint. Functionality Removal from previous version of software.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Removes NavConfig class & Replaces its use OSC/ondemand
2 participants
@johrstrom @HazelGrant