Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightlies job deletion confirmation is not longer using bootstrap #2073

Open
treydock opened this issue Jun 6, 2022 · 1 comment
Open

Nightlies job deletion confirmation is not longer using bootstrap #2073

treydock opened this issue Jun 6, 2022 · 1 comment

Comments

@treydock
Copy link
Contributor

treydock commented Jun 6, 2022

When I go to delete jobs the confirmation box is no longer using nice styles on dev. I was deleting K8 jobs but not sure if specific to K8 or other jobs too.

This is test OnDemand running 2.0.x:

This is dev OnDemand running 2.1 nightlies:

┆Issue is synchronized with this Asana task by Unito

@osc-bot osc-bot added this to the Backlog milestone Jun 6, 2022
@johrstrom
Copy link
Contributor

Thanks this is known from #1957 (comment) . The library doesn't seem to work nice with esbuild, but they're not accessible anyhow, so it's not a big loss for me at the moment anyhow. I put #665 in 2.1, so this should be there too.

In any case - it seems like we either need to decide that this is OK for now or try to fix it (and the accessibility of it) in 2.1.

@johrstrom johrstrom modified the milestones: Backlog, 2.1 Jun 6, 2022
@ritikasunkara ritikasunkara added the bug Existing functionality not working as expected label Jul 3, 2022
@Oglopf Oglopf added component/dashboard and removed bug Existing functionality not working as expected component/dashboard labels Dec 5, 2022
@johrstrom johrstrom modified the milestones: 2.1, 2.2 Jan 4, 2023
@johrstrom johrstrom modified the milestones: 3.1, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants