clamp not working right

[johrstrom]

This function clamp doesn't work right.

ondemand/apps/dashboard/app/javascript/packs/batchConnect.js

Line 393 in 9cc2123

function clamp(previous, previousBoundary, currentBoundary, comparator){

1. Take an app like jupyter that has 28 cores for owens and 48 cores for pitzer.
2. enable this javascript
3. choose pitzer and the max becomes 48
4. set # of cores to 47
5. change to owens cluster

expected behaviour at this point is that cores should be set to 28 not 47. If one chooses 48 in step 4 or skips step 4 it works. But it doesn't seem to be making the right comparisons.

[johrstrom]

It also seems like clamp needs to be outside of the [min,max] loop. There's another bug here where you clamp the max, then you clamp a second time.

So you end up shifting left (current value > new max) and then shifting right (current value < new min) when the current value is at the maximum.