Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable variable dimension (2d/3d) #58

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Sep 28, 2023

Because of the template on the input class, CabanaPD will now be a header-only library

Enable 2d or 3d simulations; primarily changes to the Particles class. Blocked by #57 which will simplify cell spacing here quite a bit. Also could block #33 since that is set up to be a 2d problem

@streeve streeve self-assigned this Sep 28, 2023
@pabloseleson
Copy link
Collaborator

@streeve : It seems here we are generalizing from 3D to a general dimension Dim. Correct? Note that when changing from 3D to 2D, one has to change the model, for example, from a fully 3D model to a 2D plane elasticity model with a change in the corresponding model constants.

@streeve
Copy link
Collaborator Author

streeve commented Oct 2, 2023

Note that when changing from 3D to 2D, one has to change the model, for example, from a fully 3D model to a 2D plane elasticity model with a change in the corresponding model constants.

Agreed, feel free to add here if it's clear how to do so the force models. But since we don't have any explicit 2d examples right now we could merge that separately

@streeve streeve merged commit fdc5596 into ORNL:main Oct 3, 2023
14 checks passed
@streeve streeve deleted the variable_dimension branch October 3, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants