[WIP] Fix build without dealii (clang-format not applied yet) #262
Conversation
dalg24
changed the title
|
We might need a runtime api call that tells whether Cap was compiled with deal.II or not to emulate the |
| @@ -1,8 +1,10 @@ | |||
| include(${CMAKE_SOURCE_DIR}/cmake/UnitTesting.cmake) | |||
|
|
|||
| if(ENABLE_DEAL_II) | |||
There was a problem hiding this comment.
Can you indent the lines below. It makes it easier to see what's in the if.
There was a problem hiding this comment.
I expect clang-format will do that.
There was a problem hiding this comment.
Oh right this is CMake... I will do that.
|
Any reason not to merge this after formatting? |
|
I think that would be fine but I don't know if @dalg24 ever tried to compile without deal.II (I assume that's why it's |
|
We need a way to find out whether Cap was built with deal.II or nor from the Python side and then we need to conditionally enable the tests with the supercapacitor. I remember I was looking at how NumPy records whether it was built with BLAS. |
|
Isn't that a separate issue besides just being able to compile without |
Yes and no. It will compile but the tests won't pass. |
fix #261