From b340cbf8a65a4b1d3c374b0f07b1fe63521fbc9b Mon Sep 17 00:00:00 2001 From: antonio Date: Fri, 18 Oct 2019 10:00:20 -0300 Subject: [PATCH 1/2] The cross method from cornerstone-math modifies the calling object. Update code to correctly use this function. --- src/lib/getImageData.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/lib/getImageData.js b/src/lib/getImageData.js index a6a5ed9c..44861672 100644 --- a/src/lib/getImageData.js +++ b/src/lib/getImageData.js @@ -23,7 +23,14 @@ export default function getImageData(imageIds, displaySetInstanceUid) { columnCosines[1], columnCosines[2] ); - const crossProduct = colCosineVec.cross(rowCosineVec); + + const crossProduct = new Vector3( + rowCosines[0], + rowCosines[1], + rowCosines[2] + ); + + crossProduct.cross(colCosineVec); const orientation = determineOrientation(crossProduct); const zAxis = computeZAxis(orientation, metaDataMap); From fc45d1167402cc24813a92d08969a213d644d878 Mon Sep 17 00:00:00 2001 From: antonio Date: Fri, 18 Oct 2019 11:35:43 -0300 Subject: [PATCH 2/2] Making code more concise --- src/lib/getImageData.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/getImageData.js b/src/lib/getImageData.js index 44861672..332b1176 100644 --- a/src/lib/getImageData.js +++ b/src/lib/getImageData.js @@ -28,9 +28,7 @@ export default function getImageData(imageIds, displaySetInstanceUid) { rowCosines[0], rowCosines[1], rowCosines[2] - ); - - crossProduct.cross(colCosineVec); + ).cross(colCosineVec); const orientation = determineOrientation(crossProduct); const zAxis = computeZAxis(orientation, metaDataMap);