fix: 🐛 Switch to orienting the volume actor differently #70
Conversation
Switch to orienting the volume actor differently depending on its acquisition direction, rather than filling up the volume differently.
|
@pieper , whenever you get a chance, please let me know if this is alright. I've tested in OHIF and it produces the same results as the previous PR. Thanks :) |
| imageData.setSpacing(xSpacing, ySpacing, zSpacing); | ||
| break; | ||
| } | ||
| imageData.setDirection(direction); |
| mapper.getInputData().getDirection() | ||
| ); | ||
| //if (!model.volumeMapper.getInputData && model.volumeMapper.getMapper) { | ||
| // mapper = model.volumeMapper.getMapper(); |
There was a problem hiding this comment.
Do you still need to leave this dead code for some reason?
There was a problem hiding this comment.
Ooh good catch, I commented it out whilst refactoring but didn't delete it.
|
🎉 This PR is included in version 0.3.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@JamesAPetts I know this has already been merged, but the reason for the volumeCoordinate space was for volumes who's data was at oblique angles but you still wanted to set the Coronal to the volume's coronal orientation. Using the I solved that by actually forcing the data to the cartesian coordinates direction, then using the direction data to modify the camera angle only for the RAS compass labels. |
Switch to orienting the volume actor differently depending on its
acquisition direction, rather than filling up the volume differently.