-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF wont load orthanc with ohif setup #4256
Comments
FYI, I have updated the sample setup to latest OHIF beta + latest Orthanc version. Still the same issue. I'm attaching the sample PDF file that I use. Study With PDF.zip Once you have launched the setup and uploaded the file in Orthanc, |
The wrong BulkDataURI is being returned by the server - if you are going to use absolute URIs, you have to have the right absolute URI.
|
I added a small PR with a working sample configuration file, and a small change to allow fixing the broken orthanc URLs. |
The response that docker is returning is for the metadata for the PDF is below, when requesting on port 3003 eg on http://localhost:3003/orthanc/dicom-web/studies/..../series/..../metadata one gets However, there is no server running on http://localhost port 80. Note the /orthanc/ as well as the port number. Other acceptable URLs would be: or the relative URL: It is possible that last URL will double up on the /orthanc/dicom-web/ port - if so, this URL should work (but should be fixed as this isn't actually standards compliant - the two above ARE standards compliant) I would suggest the instances version of it. |
I confirm I was able to update our test setup with the latest build and it works. Thanks ! |
Hi @sedghi and @wayfarer3130 I'm not sure we are 100% done with this issue :-( As mentioned in my previous comment, one of our test-setup works fine with v3.9.0-beta-56. Note that, in this setup, I'm using the standard Docker image from OHIF and therefore serving OHIF on a dedicated nginx server on http://localhost:3003 with a reverse-proxy forwarding However, when we deploy OHIF and Orthanc together (e.g in this setup), we usually have our own nginx in front of both OHIF and Orthanc. OHIF is reversed proxied at Steps to reproduce:
Thanks for your help ! Alain |
Hello, @sedghi and @wayfarer3130, are there any updates on the above. @amazy updated the issues that are yet to be resolved. Please help look into this |
Again @sedghi and @wayfarer3130, are there any updates on the above. @amazy updated the issues that are yet to be resolved. Please help look into this. Please thanks |
I have similar issues when using orthanc with ohif plugin behind an nginx proxy. Things that I found in the web such as changing configs singlepart, acceptheader, datasources in ohif configuration file did not help. |
It isn't an OHIF issue - the problem is that the path being returned by Orthanc isn't the right path any longer. There are configuration options now which can be used to deal with that, but without knowing your exact setup and examples of what the path coming back is in the metadata, and what the path should be, I can suggest how to fix it on YOUR end. Alternatively, orthanc could use relative paths, which do work correctly as long as OHIF is configured to allow that (should probalby make this a default config.) If you give me the absolute path for a metadata file AND the snipped of metadata file containing the bulkdata URI, and the actual path that actually works on your system, then I can provide a configuration that works for that setup. It won't work in general because you can configure a reverse proxy however you want and that doesn't rewrite metadata URLs. |
I will also add documentation at https://docs.ohif.org/configuration/dataSources/dicom-web exactly how to configure the BulkDataURI setting for fixing incorrect relative paths.
You need to remove bits of the path of startsWith and add the correct value for your back end with prefixWith. |
@amazy is this something we can work with. And can we try what @wayfarer3130 suggested? |
@wayfarer3130 I just gave it a try again. First, with the working test setup where OHIF is served as a standalone server on The PDF is loaded correctly: Here is the OHIF configuration:
Then, the second setup where OHIF and Orthanc are both behind the same reverse-proxy and are served at There, we assume we do not have to provide a specific OHIF configuration to correct Orthanc URIs since they are correct directly:
Then, this time, I went one step further and provided OHIF with a bulkDataUri configuration:
And, there, the PDF is displaying fine. So, to summarize, it seems that we were not just aware that we needed to enable bulkDataURI in all configurations. I thought this configuration was only required to correct wrong bulkDataURIs from Orthanc. So, if you confirm that this last remark is correct, we can close this issue and I will update all our samples. |
Thank you for the testing on that - yes, the configuration is required to
enable the bulkDataURI fetching at all from the metadata responses. That
is probably a change that should be made, plus the documentation of how to
configure the startsWith/prefix settings and the relative resolution
settings. You can leave the issue open until I've done that and I will
have it closed against the PR to address those parts of the concern - I
might ask you to retest not needing the bulkDataURI configuration at all.
…
Message ID: ***@***.***>
|
@wayfarer3130 I confirm it works without the bulkDataUri config now ! The doc looks good to me too ! Thanks to all of you ! |
Describe the Bug
Hello everyone. Pdf is not loading on Orthanc + ohif v3 docker setup . It says No PDF viewer is installed. This was working properly with version 2. Any help will be appreciated. Thank you
Steps to Reproduce
The current behavior
No online Pdf viewer installed
The expected behavior
PDF loads
OS
Ubuntu server
Node version
18
Browser
Edge 125.0.2535.96
The text was updated successfully, but these errors were encountered: