[Bug] 3.7 QA Bug Report

[james-hanks]

Issues

New Segmentation: Color of new segment doesn't change on first click

• Create new segmentation
• Change color of fist segment
• Draw segment
• Color of segment drawn is the same as last selected segment
• Change color again, segment color now changes

Feedback

• Adjust range of mm radius slider on tool size. 0.01 is too small and 99 is too large. Also, I can't see anything drawn at 0.01 size even zoomed in

[jbocce]

Swapping in an already hydrated RTSTRUCT throws an exception and results in the destination viewport of the swap becoming blank. See the video below. The exception is...

C:\dev\Viewers\extensions\cornerstone\src\services\CornerstoneCacheService\CornerstoneCacheService.ts:227 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '0')
    at CornerstoneCacheService._shouldRenderSegmentation (C:\dev\Viewers\extensions\cornerstone\src\services\CornerstoneCacheService\CornerstoneCacheService.ts:227:1)
    at CornerstoneCacheService.createViewportData (C:\dev\Viewers\extensions\cornerstone\src\services\CornerstoneCacheService\CornerstoneCacheService.ts:47:1)
    at loadViewportData (C:\dev\Viewers\extensions\cornerstone\src\Viewport\OHIFCornerstoneViewport.tsx:258:1)
    at C:\dev\Viewers\extensions\cornerstone\src\Viewport\OHIFCornerstoneViewport.tsx:304:1
    at invokePassiveEffectCreate (C:\dev\Viewers\node_modules\react-dom\cjs\react-dom.development.js:23487:1)
    at HTMLUnknownElement.callCallback (C:\dev\Viewers\node_modules\react-dom\cjs\react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (C:\dev\Viewers\node_modules\react-dom\cjs\react-dom.development.js:3994:1)
    at invokeGuardedCallback (C:\dev\Viewers\node_modules\react-dom\cjs\react-dom.development.js:4056:1)
    at flushPassiveEffectsImpl (C:\dev\Viewers\node_modules\react-dom\cjs\react-dom.development.js:23574:1)
    at unstable_runWithPriority (C:\dev\Viewers\node_modules\scheduler\cjs\scheduler.development.js:468:1)

ScreenHunter.Oct.04.15.07.mp4

[jbocce]

Filtering by study date is hostile. It results in "Unable to query for studies at this time. Check your data source configuration or network connection" page getting displayed.

ScreenHunter.Oct.04.15.40.mp4

[jbocce]

After exiting MPR with the length tool selected, the w/l tool shows selected, yet a mouse drag draws a length tool. FYI, in 3.6, no tool shows selected, but the length tool is applied with a mouse drag.

ScreenHunter.Oct.04.15.57.mp4

[jbocce]

Double clicking in MPR with cross-hairs will eventually throws exceptions in the console - sometimes sooner than later, but it has consistently done so for me. However, everything appears to function fine after that point, but I do not know for sure.

Here is one of the exceptions...

Error: <rect> attribute x: Expected length, "NaN".
(anonymous)	@	setAttributesIfNecessary.ts:8
ki	@	setAttributesIfNecessary.ts:2
Fi	@	drawHandles.ts:78
(anonymous)	@	CrosshairsTool.ts:1320
Rs.renderAnnotation	@	CrosshairsTool.ts:1117
(anonymous)	@	triggerAnnotationRender.ts:188
(anonymous)	@	triggerAnnotationRender.ts:202
Oi	@	draw.ts:10
_triggerRender	@	triggerAnnotationRender.ts:184
_renderFlaggedViewports	@	triggerAnnotationRender.ts:93
requestAnimationFrame (async)		
_render	@	triggerAnnotationRender.ts:141
_setViewportsToBeRenderedNextFrame	@	triggerAnnotationRender.ts:131
renderViewport	@	triggerAnnotationRender.ts:70
Qi	@	triggerAnnotationRender.ts:232
(anonymous)	@	triggerAnnotationRen…orViewportIds.ts:14
Po	@	triggerAnnotationRen…orViewportIds.ts:12
Rs.onCameraModified	@	CrosshairsTool.ts:661
(anonymous)	@	cameraModifiedEventDispatcher.ts:25
tm	@	cameraModifiedEventDispatcher.ts:23
se	@	triggerEvent.ts:37
triggerCameraModifiedEventIfNecessary	@	Viewport.ts:1128
setCamera	@	Viewport.ts:1103
resetCamera	@	Viewport.ts:658
resetCamera	@	VolumeViewport.ts:220
(anonymous)	@	RenderingEngine.ts:601
_resizeVTKViewports	@	RenderingEngine.ts:593
resize	@	RenderingEngine.ts:332
resize	@	CornerstoneViewportService.ts:103
(anonymous)	@	OHIFCornerstoneViewport.tsx:141
(anonymous)	@	utils.ts:50
di	@	react-dom.production.min.js:130
Yo	@	react-dom.production.min.js:184
Qs	@	react-dom.production.min.js:269
Al	@	react-dom.production.min.js:250
Ol	@	react-dom.production.min.js:250
Pl	@	react-dom.production.min.js:250
yl	@	react-dom.production.min.js:243
(anonymous)	@	react-dom.production.min.js:123
t.unstable_runWithPriority	@	scheduler.production.min.js:18
qa	@	react-dom.production.min.js:122
Qa	@	react-dom.production.min.js:123
Wa	@	react-dom.production.min.js:122
gl	@	react-dom.production.min.js:237
enqueueSetState	@	react-dom.production.min.js:133
p.setState	@	react.production.min.js:12
(anonymous)	@	utils.ts:38
(anonymous)	@	ResizeDetector.tsx:232
n.createResizeHandler	@	ResizeDetector.tsx:227
p	@	debounce.js:95
y	@	debounce.js:144
v	@	debounce.js:132
setTimeout (async)		
(anonymous)	@	debounce.js:103
b	@	debounce.js:172

ScreenHunter.Oct.04.16.05.mp4

[sedghi]

Fixed the first two
Three is tricky I'm investigating the MPR tool sync

The last one (crosshairs) having a hard time really reproducing it (was not successful even once)

[jbocce]

Fixed the first two Three is tricky I'm investigating the MPR tool sync

The last one (crosshairs) having a hard time really reproducing it (was not successful even once)

@sedghi, for the crosshairs problem, I think double clicking at the "intersection point" of the crosshairs MIGHT have something to do with it. But I am not 100% certain.

[jbocce]

The side panel segmentation list is no longer scrollable. It was in 3.6.

1. Open a not-so-tall browser window.
2. Launch https://viewer.ohif.org/viewer?StudyInstanceUIDs=1.3.12.2.1107.5.2.32.35162.30000015050317233592200000046
3. Hydrate the SEG.
4. Open the segmentation side panel. Notice that there should be 43 segments listed but the list is NOT scrollable.

[jbocce]

The hide all button is missing for basic viewer after hydrating a segmentation.

[jbocce]

Update: Fixed

Cannot launch MPR from MR SEG.

1. Launch https://viewer-dev.ohif.org/viewer?StudyInstanceUIDs=1.3.6.1.4.1.5962.99.1.2968617883.1314880426.1493322302363.3.0
2. Hydrate the SEG. Answer yes to hydrate when prompted.
3. Click the MPR button. The 1x3 layout displays with blank viewports. See the following exception.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '0')
    at At._shouldRenderSegmentation (CornerstoneCacheService.ts:229:23)
    at At.createViewportData (CornerstoneCacheService.ts:47:14)
    at OHIFCornerstoneViewport.tsx:258:58
    at OHIFCornerstoneViewport.tsx:304:5
    at Ul (react-dom.production.min.js:262:359)
    at t.unstable_runWithPriority (scheduler.production.min.js:18:343)
    at qa (react-dom.production.min.js:122:325)
    at Nl (react-dom.production.min.js:261:308)
    at yl (react-dom.production.min.js:243:50)
    at react-dom.production.min.js:123:115

[jbocce]

The hydrate SEG prompt banner sometimes stays after hydrating the SEG via the LOAD button...

ScreenHunter.Oct.05.08.42.mp4

[jbocce]

Hydrating two distinct SEGs does not result in two overlapping segmentations. At the very least the two segmentations are NOT displayed in the side panel - just one is shown.

ScreenHunter.Oct.05.08.46.mp4

[sedghi]

Reported bug Project-MONAI/MONAILabel#1554 (comment)