Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SEG/RTSTRUCT breaks Stack Image Sync after loading #3408

Closed
03shek opened this issue May 19, 2023 · 5 comments
Closed

[Bug] SEG/RTSTRUCT breaks Stack Image Sync after loading #3408

03shek opened this issue May 19, 2023 · 5 comments
Assignees
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)

Comments

@03shek
Copy link

03shek commented May 19, 2023

Describe the Bug

Stack Image Sync works in the study before a SEG is loaded, but stops working after

Steps to Reproduce

  1. On v3-demo.ohif.org, load a study and set up a pair of viewports: series 5 | series 4 in this example, which both have 79 slices:
    https://v3-demo.ohif.org/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.1706.8374.643249677828306008300337414785

  2. Enable Stack Image Sync.

  3. Scroll through either viewport and see that the two series will scroll in sync together.
    stackimagesync_beforeSEG

  4. Drag the SEG into the first viewport (series 5, its origin series).

  5. Make sure Stack Image Sync is still enabled.

  6. Scroll through either viewport and see that only the active viewport will scroll.
    stackimagesync_afterSEG

The current behavior

Stack Image Sync works in the study before a SEG is loaded, but stops working after

The expected behavior

Stack Image Sync should work with and without a SEG loaded into a viewport.

OS

OS Windows 10

Node version

16.14.0

Browser

Chrome 111.0.0

@03shek 03shek added Awaiting Reproduction Can we reproduce the reported bug? Community: Report 🐛 labels May 19, 2023
@03shek 03shek changed the title Stack Image Sync stops working after loading SEG [Bug] Stack Image Sync stops working after loading SEG/RTSTRUCT [Bug] May 19, 2023
@03shek 03shek changed the title Stack Image Sync stops working after loading SEG/RTSTRUCT [Bug] SEG/RTSTRUCT breaks Stack Image Sync after loading [Bug] May 19, 2023
@03shek 03shek changed the title SEG/RTSTRUCT breaks Stack Image Sync after loading [Bug] [Bug] SEG/RTSTRUCT breaks Stack Image Sync after loading May 25, 2023
@sedghi
Copy link
Member

sedghi commented Oct 13, 2023

Yes, since the viewports will get converted to volume viewports and stack image sync only works for stack viewports

@sedghi sedghi added Bugs Bug reported, reproducible, and verified. and removed Awaiting Reproduction Can we reproduce the reported bug? labels Oct 13, 2023
@03shek
Copy link
Author

03shek commented Nov 10, 2023

@sedghi Hi Alireza, I just tested this again on OHIF Demo v3.7 and it's still an issue.
https://viewer.ohif.org/viewer?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.1706.8374.643249677828306008300337414785

Version number 3.7.0
Commit Hash 5ddf8a1
Browser Chrome 117.0.0
OS Windows 10

Stack image sync working before SEG/RTstruct is loaded:
before

Default state after loading SEG/RTstruct:
after_default

Stack image sync broken:
after_triedscrolling

Any fixes planned?

@sedghi
Copy link
Member

sedghi commented Nov 13, 2023

Yes, in development

@sedghi
Copy link
Member

sedghi commented Dec 11, 2023

Check here #3849

@sedghi sedghi added fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org) and removed Bugs Bug reported, reproducible, and verified. labels Feb 21, 2024
@sedghi
Copy link
Member

sedghi commented May 1, 2024

We just release the OHIF 3.8, you can find more details here https://ohif.org/release-notes/3p8/
If you still encounter this issue in 3.8, please re-open this.

@sedghi sedghi closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-dev-await-release This issue is fixed in master (viewer-dev) but we are pending testing for release (viewer.ohif.org)
Projects
None yet
Development

No branches or pull requests

2 participants