Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About box reports incorrect version number #2023

Closed
pieper opened this issue Sep 1, 2020 · 9 comments
Closed

About box reports incorrect version number #2023

pieper opened this issue Sep 1, 2020 · 9 comments
Assignees
Labels
IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority

Comments

@pieper
Copy link
Member

pieper commented Sep 1, 2020

Bug Report

Describe the Bug

The about box has contradictory information. As shown below, the version number is old but this should be a build of the current master branch.

image

What steps can we follow to reproduce the bug?

Open viewer.ohif.org (or other build) and go to Options->About.

My guess is that the version is based on when the build directory was first initialized and doesn't get updated on new builds.

@pieper pieper added Community: Report 🐛 IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority labels Sep 1, 2020
@fedorov
Copy link
Member

fedorov commented Sep 24, 2020

Discussed and agreed to query idcGitVersion.txt that is available in top-level IDC deployment and show that in About. This will be done in fork, so @pieper will create an issue under fork to do this?

@pieper
Copy link
Member Author

pieper commented Oct 8, 2020

After a quick look at the webpack configuration for OHIF I think I'm not the best person to do this, or at least it would take me longer.

I believe all we need to do is add this plugin: https://www.npmjs.com/package/git-revision-webpack-plugin

and then make sure it is available to use in the dialogs. I think this would be valuable for any ohif deployment.

@JamesAPetts or @dannyrb could you help?

@pieper
Copy link
Member Author

pieper commented Oct 26, 2020

Mailto tag is fixed.

About box is more tricky and I'm seeing what the OHIF team can suggest.

@fedorov
Copy link
Member

fedorov commented Dec 3, 2020

From earlier conversation with @dannyrb:

image

@dannyrb
Copy link
Member

dannyrb commented Dec 3, 2020

Oof. Not a great comment for me to make before a long stint of vacation. Blocking off some time today to whip up a quick something.

@fedorov
Copy link
Member

fedorov commented Dec 3, 2020

Thanks @dannyrb! The intent was not to put you on the spot, but to pull together all the pieces of information related to this issue. We would most definitely appreciate your help though!

@fedorov
Copy link
Member

fedorov commented May 20, 2021

I have to admit I am not sure what is the best way to test this!

@igoroctaviano
Copy link
Contributor

I have to admit I am not sure what is the best way to test this!

  1. build the viewer (generate dist)
  2. Update version
  3. build the viewer again (should update the last dist)
  4. check the version if its updated (before the version wasn't being updated)

the version was based on when the build directory was first initialized and doesn't get updated on new builds

@fedorov
Copy link
Member

fedorov commented Jul 26, 2021

This was deployed to IDC production, and versions reported appear to be accurate.

@fedorov fedorov closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:candidate Possible feature requests for discussion, and if we agree, they can be relabeled IDC:priority
Projects
None yet
Development

No branches or pull requests

4 participants