-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About box reports incorrect version number #2023
Comments
Discussed and agreed to query idcGitVersion.txt that is available in top-level IDC deployment and show that in About. This will be done in fork, so @pieper will create an issue under fork to do this? |
After a quick look at the webpack configuration for OHIF I think I'm not the best person to do this, or at least it would take me longer. I believe all we need to do is add this plugin: https://www.npmjs.com/package/git-revision-webpack-plugin and then make sure it is available to use in the dialogs. I think this would be valuable for any ohif deployment. @JamesAPetts or @dannyrb could you help? |
Mailto tag is fixed. About box is more tricky and I'm seeing what the OHIF team can suggest. |
From earlier conversation with @dannyrb: |
Oof. Not a great comment for me to make before a long stint of vacation. Blocking off some time today to whip up a quick something. |
Thanks @dannyrb! The intent was not to put you on the spot, but to pull together all the pieces of information related to this issue. We would most definitely appreciate your help though! |
I have to admit I am not sure what is the best way to test this! |
the version was based on when the build directory was first initialized and doesn't get updated on new builds |
This was deployed to IDC production, and versions reported appear to be accurate. |
Bug Report
Describe the Bug
The about box has contradictory information. As shown below, the version number is old but this should be a build of the current master branch.
What steps can we follow to reproduce the bug?
Open viewer.ohif.org (or other build) and go to Options->About.
My guess is that the version is based on when the build directory was first initialized and doesn't get updated on new builds.
The text was updated successfully, but these errors were encountered: