-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dicom tag viewer #1129
Comments
Just a thought, maybe just using a json output with a js json reader that allows to dynamically open / close keys of the json ? |
Another feature the slicer one has is that if you doubleclick the tag it opens a browser page with a dicomlookup.com search. Would be good to add that, and/or dicom.innolitics.com/ciods . |
Ah! I've always found a DICOM Tag list helpful for development/troubleshooting. Out of curiosity, how do you determine what information to show for volumes / MPR (VTK Viewports)? This would probably make the most sense as an OHIF Extension. I think there are a couple different approaches we could take:
We could also provide the I think adding a lookup w/ |
For volume I think you can't, this can probably done only in the "raw" slice view by looking at a single serie at a particular slice. One other workflow could be to make it available on the series thumbnail with a small button that could give a small dialog to ask for the metadata of the slice N (for example able to choose value with a spinner) |
Or.. another way to not add GUI element could be to rely only on keyboard shortcut. |
In Slicer the way we do it is in the patient/study/series browser. For any selection level you have a corresponding list of instances. The metadata viewer has a slider at the top to move through the instance list and update the tree view (it updates fast so you can quickly scan for what tags change per instance). There's also a search box so you can limit what is displayed. I agree this would be fine as an extension rather than part of OHIF Core. |
Is it important that we preserve viewing of at least a single viewport (so you can see tags + slice at the same time)? Or does tag inspection make more sense in isolation (buys us more screen space)? |
Seeing the image corresponding to the header sound nice, but not always better. I could imagine it being a layout option. As in you could view a series in 'header' mode, and still have the stack scroll option and could also sync it to another series, which could be just another view of the same series but in 'image' mode instead of 'header' mode. |
I would vote for the simplest implementation as the first step, and then prioritize and refine as the specific needs come up. Simple list taking the whole viewport sounds fine. I can see how "Search" in column headers can be useful. I can't think of a use case that would justify the need to show image at the same time. @swederik how does MedDream's interface handle sequences? |
As discussed today with @swederik @pieper and @JamesAPetts, one useful feature to consider could be integration with Innolitics DICOM browser, which links content of the individual files with the matching definitions and CIOD. cc: @johndgiese |
Closed as first iteration done. Post MVP improvements/feedback can come in other tickets 👍 . |
Hey @JamesAPetts, I'm probably setting it up wrong but I tried to take a look at the MVP for this extension and failed to do to: |
Quickly looking at your screenshot... you might have found a bug too (maybe not related to your problem). Both debugging and dicom-tag-browser uses the same library name in their webpack prod files: |
To enable "Tag browser" extension, uncomment these lines: Viewers/platform/viewer/src/index.js Line 32 in 755b283
Viewers/platform/viewer/src/index.js Line 57 in 755b283
|
Request
Would be great to be able to look at the whole structure of the dicom metadata.
What feature or change would you like to see made?
Probably easiest to add a tree view that syncs to image scroll.
Basic function would be to have it provide the same features as Slicer ore similar.
https://www.slicer.org/wiki/File:DICOM4_2014-11-17-09-38.png
Why should we prioritize this feature?
It's helpful for debugging.
The text was updated successfully, but these errors were encountered: