Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null name column issue in 1.4.3 will result in Java Number Format Error #136

Open
lofung opened this issue Jun 10, 2021 · 3 comments
Open
Labels

Comments

@lofung
Copy link

lofung commented Jun 10, 2021

As forum post in june 2021.

https://forums.ohdsi.org/t/usagi-java-number-format-error/11395

a null name forum as like

code, details, , ,, , , , test

seems to result in java.lang.NumberFormatException: For Input string: “”

@MaximMoinat
Copy link
Collaborator

MaximMoinat commented Jun 10, 2021

The way I could reproduce the error, was to import a file with empty cells in the frequency column (or when the input has a completely empty row). Usagi tries to convert the empty string to a number, which fails. To fix this, I suggest we assign a frequency of 1 to any missing frequencies.

@lofung can you check that this is indeed the issue with your input file? e.g. by using the same file, but not importing the frequency column. I can't reproduce issues with empty column names.

@lofung
Copy link
Author

lofung commented Jun 21, 2021

it seems it has to do with the "header" columns, aka first column of the txt that contains the column titles. I have further find another issue today. It seems that either it cannot do with null or "space char" character

result in java.lang.NumberFormatException: For Input string: “”
both results in

@MaximMoinat
Copy link
Collaborator

MaximMoinat commented Jun 21, 2021

@lofung I was not able to reproduce an issue with empty header cells. Could you share the file you are trying to import?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants