-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location Table Updates #91
Comments
I think inputting the location information in the observation table would be an alternative for 'Add a way to capture region' |
I would like to know when the extended location model presented in this issue will be reflected in the OMOP-CDM version. Will it be reflected in the next OMOP-CDM update? |
I second that. Let's get the least controversial fields latitude and longitude in to the location table, at least |
@gowthamrao: What's controversial about the others? I wouldn't call the field "zip" but postalcode (zip is an utterly American thing), and I might challenge whether we can merge the region or county fields, but that's not very controversial. If you think it's ready bring it on. @clairblacketer holds the meeting agenda strings. |
Exactly. You just mentioned all the controversies. Region, zip, etc. Lat and long are non controversial. We need to propose that ASAP and try to incorporate into CDM. |
Bring it on. |
@gowthamrao @cgreich I'll add this to the agenda for next Tuesday and I will invite Robert Miller as well from the GIS workgroup. |
Well, all of those guys say they just want country (which I don't understand why, since the value will always be the same in a database, with rarest exceptions). Only Robert has GIS, and the Koreans. Want to invite those? |
Sure - I invited Robert Miller already and I will extend the invite to the Koreans as well. |
We didn't have time during the CDM call today to discuss this proposal so I figured I'd put my two cents down while the idea is still fresh. To preface, this ignores the other discussion of how to enable the location table to be internationally friendly (in addition to adding a field to represent altitude as Melanie Philofsky has suggested) as I assume it's best to distinguish the topics. In short, my revised proposal is nearly the exact format that @gowthamrao put forward in his proposal (happy 1 year anniversary Gowtham's post!). The only difference would be to increase the size limit of the country field to 100 characters or so, just in case. TODO: Data mine Gowtham's forum post history, pass off ideas as my own Is there anyone who disagrees with adding latitude and longitude columns? It appears to be low hanging fruit that we could push forward if we get hung up on the other modifications to the location table. Differences from current proposal1 ) Use free text instead of ISO codes to represent countries
2 ) Do not maintain a reference to a region within the location table
|
@rtmill good post. Altitude - can't it be derived at analytics time? Are there any use case to have altitude only on location table without lat and long? If lat and long are prerequisites, then can't altitude be derived from it thru a lookup? |
We, University of Colorado Denver, are interested in altitude data as a criteria to include patients in a cohort. |
added in v6.0 |
Location Table Updates
Proposal
Relevant table: Location
Conventions
The text was updated successfully, but these errors were encountered: