Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Note_event_id from CDM Version 6 model specification. #371

Closed
chandryou opened this issue Nov 3, 2020 · 3 comments
Closed

Removed Note_event_id from CDM Version 6 model specification. #371

chandryou opened this issue Nov 3, 2020 · 3 comments
Assignees

Comments

@chandryou
Copy link

Previously, the proposal for adding Note_event_id to the NOTE table was accepted (#172).
This change was reflected in the CDM v6 specification PDF.

However, I've just noticed that CDM v6 specification in the web does not include Note_event_id in the NOTE table.

Is there any specific reason for this change?

@w0ut0
Copy link

w0ut0 commented Nov 10, 2020

Hi @chandryou, I have the same issue. Is it possible the doucmentation of 5.3.1 is published to the documentation page of 6.0?

1 example is visit_occurrence.admitting_source_concept_id

When I look at the documentation for v 5.3.1 and 6.0 it should exist in both version.

However, when looking at the ddl for sql server (https://github.com/OHDSI/CommonDataModel/blob/master/Sql%20Server/OMOP%20CDM%20sql%20server%20ddl.txt#L276), it's not included. I think the DDL is correct and the documentation not (anymore).

Maybe @clairblacketer or @ericaVoss can help us shed some light?

@clairblacketer
Copy link
Contributor

Thanks @chandryou and @w0ut0 this is an error in the CDM documentation and not in the DDL. I will work to get this fixed.

@clairblacketer clairblacketer self-assigned this Nov 13, 2020
@w0ut0
Copy link

w0ut0 commented Nov 24, 2020

@clairblacketer could we temporarily put up a note saying the documentation is not correct? I have some team members implementing ETL and mistakes are being made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants