Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime fields in DDL for SQL Server #171

Closed
cukarthik opened this issue Mar 22, 2018 · 2 comments
Closed

Datetime fields in DDL for SQL Server #171

cukarthik opened this issue Mar 22, 2018 · 2 comments

Comments

@cukarthik
Copy link
Contributor

Datetime fields in the SQL Server DDL use the datetime type; however, SQL Server generally recommends datetime2 instead of datetime.

This StackOverflow post references Microsoft's shift to datetime2.

@cukarthik cukarthik changed the title DDL for SQL Server Datetime fields in DDL for SQL Server Mar 22, 2018
@cukarthik
Copy link
Contributor Author

@clairblacketer if you have a chance, can you let me know what you think, and I can update the SQL Server DDL and do a pull request.

@clairblacketer
Copy link
Contributor

@cukarthik this change looks good to me, go ahead and create a PR. The other DDLs feed off of the SQL Server DDL through SQLRender so making the change there will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants