Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch domain_ID to table_ID #164

Closed
clairblacketer opened this issue Feb 13, 2018 · 7 comments
Closed

Switch domain_ID to table_ID #164

clairblacketer opened this issue Feb 13, 2018 · 7 comments
Assignees
@clairblacketer
Labels
Enhancement

Comments

@clairblacketer
Copy link
Contributor

change any reference to domain_id to table_id/table_name in version 6.0
@gowthamrao
Copy link
Member

@clairblacketer table_id or table_concept_id?

@cgreich
Copy link
Contributor

cgreich commented Feb 14, 2018

And table_field_concept_id.

@cgreich cgreich closed this as completed Feb 14, 2018
@cgreich cgreich reopened this Feb 14, 2018
@gowthamrao gowthamrao mentioned this issue Apr 4, 2018
Closed
@clairblacketer
Copy link
Contributor Author

@cgreich I created an issue on the vocab github to address this

@clairblacketer clairblacketer mentioned this issue May 11, 2018
Closed
@vojtechhuser
Copy link
Collaborator

are there now condept_ids for each table and column? If yes - please link one example here.

@clairblacketer
Copy link
Contributor Author

related to #139

@gowthamrao gowthamrao mentioned this issue Aug 7, 2018
Closed
@clairblacketer clairblacketer self-assigned this Sep 25, 2018
@clairblacketer
Copy link
Contributor Author

instead of *_event_domain_id, fields will be called *_event_field_concept_id to code for the field the event id is coming from.

@gowthamrao gowthamrao mentioned this issue Sep 30, 2018
Closed
This was referenced Oct 11, 2018
Merged
Merged
@clairblacketer
Copy link
Contributor Author

added in v6.0

@clairblacketer clairblacketer mentioned this issue Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clairblacketer clairblacketer

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cgreich @vojtechhuser @clairblacketer @gowthamrao