Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source clean up for 2.3 release? #245

Closed
oldmanauz opened this issue Nov 12, 2021 · 3 comments
Closed

Source clean up for 2.3 release? #245

oldmanauz opened this issue Nov 12, 2021 · 3 comments

Comments

@oldmanauz
Copy link
Contributor

oldmanauz commented Nov 12, 2021

@darksylinc, In preperation for a 2.3 release soon(I'm guessing ??) I was looking around the code and to me it looked like a lot of legecy code could be cleaned up. I can do a PR for it, I just wanted to check if it was a good idea or not. Potential clean ups:

  1. Components cleanup:
  • Paging component source removed - Ogre code that hasn't been ported to Ogre Next yet?
  • RTShaderSystem component source removed - legecy code from Ogre that isn't used anymore?
  • Terrain component source removed - Ogre code that hasn't been ported to Ogre Next yet?
  • Volume component source removed - Ogre code that hasn't been ported to Ogre Next yet?
  1. Plugin cleanup:
  • BSP plugin source removed - Ogre code that hasn't been ported to Ogre Next yet?
  • Octree Scene Manager plugin source removed - Ogre code that hasn't been ported to Ogre Next yet?
  • Octree Zone plugin source removed - Ogre code that hasn't been ported to Ogre Next yet?
  • PCZ Scene Manager plugin source removed - Ogre code that hasn't been ported to Ogre Next yet?
  1. Rendersystem cleanup:
  • DirectX9 Render System source removed - legecy code from Ogre that isn't used anymore?
  • GLES2 Render System source removed - legecy code from Ogre that isn't used anymore?
  1. NaCl platform removal - legecy code from Ogre that isn't used anymore?
  2. Clean up Media folder and remove unused stuff from Ogre samples.
  3. CMAKE cleanup:
  • Remove legecy componetns, plugins and rendersystems from the configuration
  • Remove the threading config options: OGRE_CONFIG_THREADS & OGRE_CONFIG_THREADS_PROVIDER
  • Remove boost stuff from CMAKE - assuming this isn't used anywhere any more?
  1. Any interest in a refresh for the docs? Options I breifly looked at.

Thoughts?

@darksylinc
Copy link
Member

darksylinc commented Nov 12, 2021

Ticket #235 is for 2.4 and will focus on a long needed cleanup

I don't want to rock the boat so close to 2.3's release (I've had my hands full past three weeks, which is why we haven't released yet)

Some of the stuff you're mentioning should be added to that ticket

@oldmanauz
Copy link
Contributor Author

I'll merge these ideas with that and close.

@darksylinc
Copy link
Member

Another reason is that I want to do the name change before it has lots of merge conflicts due to deleted/moved files

@oldmanauz oldmanauz mentioned this issue Nov 12, 2021
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants