Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge_gridded_data to tutorials #118

Open
pat-schmitt opened this issue Feb 27, 2024 · 1 comment
Open

Add merge_gridded_data to tutorials #118

pat-schmitt opened this issue Feb 27, 2024 · 1 comment

Comments

@pat-schmitt
Copy link
Member

pat-schmitt commented Feb 27, 2024

Add an explanation of merge_gridded_data somewhere in the tutorials, I am not sure at the moment at which place.

Adapt distribute_flowline tutorial:

  • Add an explanation of new merging functionality for dynamic runs to this tutorial, added in PR Merge gridded data oggm#1674.
  • Also need to rename distributed_thickness to simulated_thickness in this notebook.
@pat-schmitt pat-schmitt changed the title Adapt distribute_flowline tutorial Add merge_gridded_data to tutorials Feb 27, 2024
@bearecinos
Copy link
Member

Hey @pat-schmitt I found another issue with the tutorials ... in distribute_thickness_from_simulation you assume that add_smoothed_glacier_topo and assign_points_to_band have been run before that task but the tutorials do not reflect that.

 # This is to add a new topography to the file (smoothed differently)
workflow.execute_entity_task(distribute_2d.add_smoothed_glacier_topo, gdirs)
# This is to get the bed map at the start of the simulation
workflow.execute_entity_task(tasks.distribute_thickness_per_altitude, gdirs)
# This is to prepare the glacier directory for the interpolation (needs to be done only once)
workflow.execute_entity_task(distribute_2d.assign_points_to_band, gdirs);

Maybe modify the order above in the notebook. Took me a bit to work it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants