Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NZSL - 27 Vocab sidebar doesn't update correctly when some signs are added directly from the search results and others from the sign page #380

Open
louise-r-blue opened this issue Oct 2, 2018 · 0 comments
Open

NZSL - 27 Vocab sidebar doesn't update correctly when some signs are added directly from the search results and others from the sign page #380

louise-r-blue opened this issue Oct 2, 2018 · 0 comments
Labels
enhancement help wanted Needs discussion to do

Comments

@louise-r-blue
Copy link
Contributor

louise-r-blue commented Oct 2, 2018 •
edited by DSRU
Loading

This story relates to the browser back button and a potential over ride of its default behaviour from the signs show page. Currently when a user clicks their default browser button to navigate back to their previously viewed page any glosses the user added to a their vocab sheet does not display. This leads the user to think that they have lost any additions to their vocab sheet that they made.

When selected the user should be taken to a refreshed instance of their last search so that the vocab sheet sidebar is also refreshed. See NZSL‌-27 for more details.

Please note: Overriding browser default behaviours is not considered good practice so an alternative solution is sought.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Needs discussion to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louise-r-blue