We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We seem to have a bug from very early on that never surfaced:
Obviously, nowhere in the CLI params there is a setting for the ocrd_tool.
However, our Processor decorator ocrd_cli_wrap_processor does take such a kwarg:
ocrd_cli_wrap_processor
core/ocrd/ocrd/decorators/__init__.py
Line 26 in 5512569
It does nothing but pass it on to run_processor:
run_processor
Line 117 in 5512569
In that context, ocrd_tool could be meaningful (e.g. when running a processor from API):
ocrd_tool
core/ocrd/ocrd/processor/helpers.py
Line 38 in 5512569
So it gets passed onto the processor constructor:
Lines 87 to 91 in 5512569
Still, this is not usually a problem, because all of our Processor subclasses simply override that kwarg.
But what if they just default to their own value?
IMO the top-level ocrd_tool param is wrong must be removed.
The text was updated successfully, but these errors were encountered:
Thanks for digging into and solving this. I am not sure why we had the ocrd_tool in there in the first place.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
We seem to have a bug from very early on that never surfaced:
Obviously, nowhere in the CLI params there is a setting for the ocrd_tool.
However, our Processor decorator
ocrd_cli_wrap_processor
does take such a kwarg:core/ocrd/ocrd/decorators/__init__.py
Line 26 in 5512569
It does nothing but pass it on to
run_processor
:core/ocrd/ocrd/decorators/__init__.py
Line 117 in 5512569
In that context,
ocrd_tool
could be meaningful (e.g. when running a processor from API):core/ocrd/ocrd/processor/helpers.py
Line 38 in 5512569
So it gets passed onto the processor constructor:
core/ocrd/ocrd/processor/helpers.py
Lines 87 to 91 in 5512569
Still, this is not usually a problem, because all of our Processor subclasses simply override that kwarg.
But what if they just default to their own value?
IMO the top-level ocrd_tool param is wrong must be removed.
The text was updated successfully, but these errors were encountered: