Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP]mrp_multi_level, specific group to run mrp manually #492

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

AaronHForgeFlow
Copy link
Contributor

When the MRP involves deep BOMs and many products are under MRP, the process may take much time. The schedule action runs every day so the need of running it manually is not under normal execution. In order to prevent running this process when it is not needed, I think it would be a good idea to hide this option except for very specific users.

Suggestions are welcome.

cc @LoisRForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @jbeficent, @lreficent,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

</record>

<record id="mrp.group_mrp_manager" model="res.groups">
<field name="implied_ids" eval="[(4, ref('mrp_multi_level.group_mrp_multi_level_run'))]" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make any production manager able to run the wizard, ant you cannot unselect it because it is implied... I think it is better if you remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree, my intention was not to modify current behavior but that's not ok.

<record id="group_mrp_multi_level_run" model="res.groups">
<field name="name">Run MRP Manually</field>
<field name="implied_ids" eval="[(4, ref('base.group_user'))]" />
<field name="category_id" ref="base.module_category_hidden" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add admin user here by default, I will be the most common when you have a fresh installation.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically this: <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) can I do the same thing for the group "Show full accounting Features"? 😇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha that would be the best fix ever ;)

@AaronHForgeFlow AaronHForgeFlow force-pushed the 12.0-imp-mrp_multi_level branch from f944ff3 to c87a727 Compare March 31, 2020 12:45
@LoisRForgeFlow LoisRForgeFlow self-requested a review April 1, 2020 09:37
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locallly, not working:
image

image

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I tried in a fresh installation and it works. For some reason, updating the module in an existing installation didn't work.

LGTM

@LoisRForgeFlow LoisRForgeFlow force-pushed the 12.0-imp-mrp_multi_level branch from c87a727 to 24b9b15 Compare April 9, 2020 12:17
@LoisRForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-492-by-LoisRForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 281032c into OCA:12.0 Apr 9, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e2ed680. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants