Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two fields.... same label.... "Params" .... v16 #371

Open
legacyplumbing opened this issue May 21, 2024 · 3 comments
Open

Two fields.... same label.... "Params" .... v16 #371

legacyplumbing opened this issue May 21, 2024 · 3 comments
Labels

Comments

@legacyplumbing
Copy link

OCB odoo v16

Installed OCA/geospatial.... 'Geospatial support for base_geolocalize'

2024-05-21 05:18:06,348 28186 WARNING blounts.5.14.24 odoo.addons.base.models.ir_model: Two fields (params_wms, params) of geoengine.raster.layer() have the same label: Params. [Modules: base_geoengine and base_geoengine]

Thank ya'll!

@legacyplumbing
Copy link
Author

Is there any info needed to help with this?

@legacyplumbing
Copy link
Author

After reviewing 'fixes' from other repos with the two field, same label issue... believe the issue is located in...
geospatial/base_geoengine/i18n/base_geoengine.pot
Lines 499-503

#. module: base_geoengine
#: model:ir.model.fields,field_description:base_geoengine.field_geoengine_raster_layer__params
#: model:ir.model.fields,field_description:base_geoengine.field_geoengine_raster_layer__params_wms
msgid "Params"
msgstr ""

Wish I could assist more... but trial and error, comparisons, and a mashup of somewhat related google searches are about all I've got in my tool bag.

@yvaucher
Copy link
Member

The issue is on the definition of the fields themselves

https://github.com/OCA/geospatial/blob/16.0/base_geoengine/models/geo_raster_layer.py#L48-L51

The first is named "Params" because the field technical name is params and it's auto converted to "Params"
The second params_wms has a specific label defined to "Params"

Seems to me that both labels should be "Parameters" and "Parameters WMS" (for filters in search view to differentiate them). But can be named both "Parameters" in the Form view as it is contextual.

The fields can be viewed there when changing the raster layer type, in each screen capture the field Params is a different one:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants