Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
PatoBeltran committed Jul 18, 2018
1 parent df33fd7 commit 6006504
Show file tree
Hide file tree
Showing 35 changed files with 72 additions and 153 deletions.
2 changes: 1 addition & 1 deletion build/common.project.props
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<DefineConstants>TRACE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<PropertyGroup>
<MinimumVisualStudioVersion>15.0</MinimumVisualStudioVersion>
<DefineConstants>$(DefineConstants);VS15</DefineConstants>
<VSSDKRoot>$(RepositoryRootDirectory)packages\Microsoft.VSSDK.BuildTools.15.1.192</VSSDKRoot>
Expand Down
2 changes: 1 addition & 1 deletion build/vsts_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ phases:
FullVstsBuildNumber: $[dependencies.Initialize_Build.outputs['updatebuildnumber.FullVstsBuildNumber']]
condition: "and(succeeded(),eq(variables['RunFunctionalTestsOnWindows'], 'true')) "
queue:
name: VSEng-MicroBuildSxS
name: VSEng-MicroBuildVS2017
timeoutInMinutes: 120
demands:
- DotNetFramework
Expand Down
2 changes: 1 addition & 1 deletion src/NuGet.Clients/NuGet.Console/NuGet.Console.csproj
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<PropertyGroup>
<Shipping>true</Shipping>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />

<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
Expand All @@ -19,7 +19,7 @@
<RestoreProjectStyle>PackageReference</RestoreProjectStyle>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
</PropertyGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<Reference Include="Microsoft.VisualStudio.VCProjectEngine, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
<EmbedInteropTypes>True</EmbedInteropTypes>
</Reference>
Expand Down Expand Up @@ -65,18 +65,16 @@
<Reference Include="WindowsBase" />
<Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL" />
</ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<Reference Include="Microsoft.Build">
<HintPath>$(SolutionPackagesFolder)Microsoft.Build.15.1.262-preview5\lib\net46\Microsoft.Build.dll</HintPath>
<Private>False</Private>
</Reference>
</ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<Compile Include="Projects\LegacyPackageReferenceProject.cs" />
<Compile Include="Projects\LegacyPackageReferenceProjectProvider.cs" />
<Compile Include="Migrate\ProjectJsonToPackageRefMigrator.cs" />
</ItemGroup>
<ItemGroup>
<Compile Include="CommonResources.cs" />
<Compile Include="Common\AsyncLockAwaiter.cs" />
<Compile Include="Common\AsyncLockReleaser.cs" />
Expand Down Expand Up @@ -113,17 +111,17 @@
<Compile Include="PackageFeeds\SearchResult.cs" />
<Compile Include="PackageFeeds\SourceRepositoryExtensions.cs" />
<Compile Include="PackageFeeds\UpdatePackageFeed.cs" />
<Compile Include="Services\DeferredProjectWorkspaceService.cs" Condition="'$(VisualStudioVersion)' == '15.0'" />
<Compile Include="Services\DeferredProjectWorkspaceService.cs" />
<Compile Include="IDE\ExtensibleSourceRepositoryProvider.cs" />
<Compile Include="IInteractiveLoginProvider.cs" />
<Compile Include="InteractiveLoginProvider.cs" />
<Compile Include="Projects\NetCorePackageReferenceProject.cs" Condition="'$(VisualStudioVersion)' == '15.0'" />
<Compile Include="Projects\NetCorePackageReferenceProject.cs" />
<Compile Include="Projects\INuGetProjectProvider.cs" />
<Compile Include="Projects\MSBuildNuGetProjectProvider.cs" />
<Compile Include="Projects\ProjectJsonProjectProvider.cs" />
<Compile Include="Projects\ProjectKNuGetProjectProvider.cs" />
<Compile Include="Projects\ProjectSystemCache.cs" />
<Compile Include="Projects\NetCorePackageReferenceProjectProvider.cs" Condition="'$(VisualStudioVersion)' == '15.0'" />
<Compile Include="Projects\NetCorePackageReferenceProjectProvider.cs" />
<Compile Include="Projects\ProjectProviderContext.cs" />
<Compile Include="ProjectServices\VsProjectScriptHostService.cs" />
<Compile Include="Prompts\DeprecatedFrameworkModel.cs" />
Expand Down Expand Up @@ -199,7 +197,7 @@
<Compile Include="Projects\IVsProjectAdapterProvider.cs" />
<Compile Include="Services\IVsProjectThreadingService.cs" />
<Compile Include="ProjectServices\VsProjectBuildProperties.cs" />
<Compile Include="ProjectServices\VsManagedLanguagesProjectSystemServices.cs" Condition="'$(VisualStudioVersion)' == '15.0'" />
<Compile Include="ProjectServices\VsManagedLanguagesProjectSystemServices.cs" />
<Compile Include="Projects\VsProjectAdapter.cs" />
<Compile Include="Projects\VsProjectAdapterProvider.cs" />
<Compile Include="ProjectServices\VsCoreProjectSystemServices.cs" />
Expand Down
4 changes: 2 additions & 2 deletions src/NuGet.Clients/NuGet.Tools/NuGet.Tools.csproj
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.common.props')" />
<!-- No bootstrapping on XPLAT, this project is not expect to work correctly-->
Expand All @@ -24,7 +24,7 @@
</FileUpgradeFlags>
<UpgradeBackupLocation>
</UpgradeBackupLocation>
<OldToolsVersion>14.0</OldToolsVersion>
<OldToolsVersion>15.0</OldToolsVersion>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="14.0" DefaultTargets="Build">
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0" DefaultTargets="Build">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.common.props')" />
<Import Project="$(VSSDKRoot)\build\Microsoft.VSSDK.BuildTools.props" Condition="'$(IsXplat)' != 'true' AND '$(IsBuildOnlyXPLATProjects)' != 'true' " />
Expand All @@ -26,10 +26,8 @@
<MinimumVisualStudioVersion>15.0</MinimumVisualStudioVersion>
<FileUpgradeFlags />
<UpgradeBackupLocation />
<OldToolsVersion>14.0</OldToolsVersion>
<OldToolsVersion>15.0</OldToolsVersion>
<RestoreProjectStyle>PackageReference</RestoreProjectStyle>
</PropertyGroup>
<PropertyGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<IsProductComponent>true</IsProductComponent>
<ExtensionInstallationRoot>CommonExtensions</ExtensionInstallationRoot>
<ExtensionInstallationFolder>Microsoft\NuGet</ExtensionInstallationFolder>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<RootNamespace>NuGet.VisualStudio</RootNamespace>
</PropertyGroup>

<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<Reference Include="Microsoft.VisualStudio.ProjectSystem">
<HintPath>$(EnlistmentRoot)\packages\Microsoft.VisualStudio.ProjectSystem.15.0.582-pre-g76aab6d79c\lib\net46\Microsoft.VisualStudio.ProjectSystem.dll</HintPath>
</Reference>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<ProjectReference Include="..\NuGet.VisualStudio\NuGet.VisualStudio.csproj" />
<ProjectReference Include="..\NuGet.VisualStudio.Common\NuGet.VisualStudio.Common.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<Reference Include="Microsoft.VisualStudio.ProjectSystem">
<HintPath>$(EnlistmentRoot)\packages\Microsoft.VisualStudio.ProjectSystem.15.0.582-pre-g76aab6d79c\lib\net46\Microsoft.VisualStudio.ProjectSystem.dll</HintPath>
</Reference>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ItemGroup>
<ProjectReference Include="..\NuGet.VisualStudio\NuGet.VisualStudio.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '15.0'">
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" Version="15.0.26201" />
<PackageReference Include="Microsoft.VisualStudio.ComponentModelHost" Version="15.0.26201" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\build\common.legacy.props" />
<PropertyGroup>
<Shipping>true</Shipping>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public static XDocument GenerateEmptyImportsFile()
new XDeclaration("1.0", "utf-8", "no"),

new XElement(Namespace + "Project",
new XAttribute("ToolsVersion", "14.0"),
new XAttribute("ToolsVersion", "15.0"),
new XElement(Namespace + "PropertyGroup",
new XElement(Namespace + "MSBuildAllProjects", "$(MSBuildAllProjects);$(MSBuildThisFileFullPath)"))));

Expand Down
13 changes: 5 additions & 8 deletions test/EndToEnd/NuGet.Tests.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,11 @@ Register-TabExpansion 'Run-Test' @{
function Rearrange-Tests {
param($tests)

if ($VSVersion -eq "15.0")
{
# Tracked by issue: https://github.com/NuGet/Home/issues/2387
# And, the commit is linked to the issue
# TODO: PackageRestore tests should be fixed and enabled or deleted
# They were only ever running on Dev10.
$tests = $tests | ? {!($_.Name -like 'Test-PackageRestore*') }
}
# Tracked by issue: https://github.com/NuGet/Home/issues/2387
# And, the commit is linked to the issue
# TODO: PackageRestore tests should be fixed and enabled or deleted
# They were only ever running on Dev10.
$tests = $tests | ? {!($_.Name -like 'Test-PackageRestore*') }

$tests
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|ARM">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<Filter Include="Common">
<UniqueIdentifier>$guid1$</UniqueIdentifier>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down
6 changes: 3 additions & 3 deletions test/EndToEnd/ProjectTemplates/UAPApp.zip/UAPApp.csproj
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand Down Expand Up @@ -130,8 +130,8 @@
</Page>
</ItemGroup>

<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '14.0' ">
<VisualStudioVersion>14.0</VisualStudioVersion>
<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' ">
<VisualStudioVersion>15.0</VisualStudioVersion>
</PropertyGroup>

<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<ProjectGuid>{$guid1$}</ProjectGuid>
<RootNamespace>$safeprojectname$</RootNamespace>
<DefaultLanguage>en-US</DefaultLanguage>
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
<MinimumVisualStudioVersion>15.0</MinimumVisualStudioVersion>
<AppContainerApplication>true</AppContainerApplication>
<ApplicationType>Windows Store</ApplicationType>
<WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.15063.0</WindowsTargetPlatformVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<Keyword>DynamicLibrary</Keyword>
<RootNamespace>$safeprojectname$</RootNamespace>
<DefaultLanguage>en-US</DefaultLanguage>
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
<MinimumVisualStudioVersion>15.0</MinimumVisualStudioVersion>
<AppContainerApplication>true</AppContainerApplication>
<ApplicationType>Windows Store</ApplicationType>
<WindowsTargetPlatformVersion>10.0.15063.0</WindowsTargetPlatformVersion>
Expand Down
Loading

0 comments on commit 6006504

Please sign in to comment.