Packaging Icon within the nupkg

Status: Reviewing
Author(s): Karan Nandwani (@karann9)

Issue

The work for this feature and the discussion around the Icon specific spec is tracked by Package Icon should be able to come from inside the package #352

Icon

The icon image will be a part of the nupkg
New nuspec property <icon src="icon.png" target=""/>
- target defaults to package root
- Supported formats - jpg, png
- On pack, strip source value, append the target value with the source file name - <icon target="icon.png"/>. (this is to help the gallery and the client know the path to the icon file in the package and the file name.extension.)
- Stretch goal - if icon.png or icon.jpg is present at the folder/project root, and icon property is not present in the nuspec/project file, nuget pack should pack that file as the package icon.
Browse from NuGet.org
- During package ingestion, nuget.org will extract and store the icon.
- For existing packages, the gallery would read the iconurl from the nuspec, fetch the image and store it.
- For search, registration metadata, and v2 API (basically any service that customers hit where we expose the icon URL), the icon URL would be replaced with URL to the gallery hosted image location. These are the APIs that are called by Visual Studio when a user is on the "Browse" tab of the package manager UI. No client change would be required for this part.
Installed packages
- Client will read the image from the global packages folder
- For new packages, on package installation, the icon would also be extracted to the global packages folder and will be used as the image source to display the icon for installed packages.
- For existing packages, on package installation, cache the icon to the global packages folder during installation (installing using dotnet CLI, will do the right thing to ensure the icon is available to the PMUI when the project is opened in VS.)
Browse from folder based feed (including VS Offline Packages source) - read the icon from the nupkg. (similar to how we read the nuspec for such packages today)
Browse from the fallback folder - the packages would be pre-extracted. Read the icon from the extracted location.
Project properties
- Replace Icon URL with Icon, keeping it a free text field (for the MVP) that takes the path to the image on disk relative to the project file. (In Dev16, we'll consider adding a file picker.)
- In project file <PackageIcon source="icon.png", target=""/>
- Set the PackageIcon property in the project file to icon file name
- On pack, strip source value, append the target value with the source file name. The icon will be placed at the package root and the nuspec property icon will be set to <icon target="icon.png"/> indicating that the icon file is named icon.png and is as the package root.

Other considerations

NuGet.org admin view to remove the package icon and block it from being displayed on NuGet.org or in VS during browse
Size recommendation - 128x128 (on nuget.org we use a max of 76.5x76.5 and in VS 32x32)

Validations

If the icon file is not found at the path listed under icon (this will also prevent template values from making into the system)
- Error nuget pack and nuget push
- Fail package validation on NuGet.org
- PMUI fail silently when browsing packages from a folder based feed
If iconurl is present
- Error nuget pack and nuget push
- Fail package validation on NuGet.org (synchronous validation)