Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.CommandLine.XPlat package add support --config #6210

Closed
wli3 opened this issue Nov 21, 2017 · 6 comments
Closed

NuGet.CommandLine.XPlat package add support --config #6210

wli3 opened this issue Nov 21, 2017 · 6 comments
Labels
Area:RestoreTool V1/V2 tool restore Platform:Xplat Priority:2 Issues for the current backlog. Product:dotnet.exe Type:DCR Design Change Request
Milestone

Comments

@wli3
Copy link

wli3 commented Nov 21, 2017

CLI tools ask (optional).

Without this CLI are coping the config file to the temporary project root. It would be real nice to have this opinion so only path to the nuget config file is needed.

@nkolev92
Copy link
Member

nkolev92 commented Dec 7, 2017

Discussed offline, this is nice to have, but not a priority or a requirement for global tools.

@nkolev92 nkolev92 modified the milestones: 4.6, Backlog Dec 7, 2017
@nkolev92 nkolev92 added the Priority:2 Issues for the current backlog. label Dec 7, 2017
@jainaashish
Copy link

design has changed so it is no more required.

@wli3
Copy link
Author

wli3 commented Jan 10, 2018

Hi @jainaashish Could you illustrate the design change? For global tools, we are using a non ideal walk around(copy the config file to fake project location). We still hope this feature can be implemented

@jainaashish
Copy link

@nkolev92 can give more details here. Since he suggested that we don't need this feature anymore.

@nkolev92
Copy link
Member

@wli3
The add command is not used in the global tools implementation though.

We're using the MsBuild property to set the starting point to iterate the config file.

@wli3
Copy link
Author

wli3 commented Jan 11, 2018

Thanks! This issue is no longer needed.

I can replace dotnet add with restore with version * and add RestoreConfigFile to fake project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreTool V1/V2 tool restore Platform:Xplat Priority:2 Issues for the current backlog. Product:dotnet.exe Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

5 participants