Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make symbols package (auto) push failure a warning for the push operation #6101

Closed
anangaur opened this issue Oct 25, 2017 · 3 comments
Closed
Assignees
Labels
Functionality:Push Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request
Milestone

Comments

@anangaur
Copy link
Member

If the user creates a symbols package along with the NuGet package and then tries to push the package to NuGet.org, NuGet does the following (non-atomic steps):

  1. Pushes the NuGet package to NuGet.org
  2. Pushes the Symbols package (if present in the same folder) to SymbolSource.org (https://nuget.smbsrc.net)

If the Step 2 fails, the NuGet package is already pushed to NuGet.org but the push operation returns failure. This is not entirely correct as the primary push did pass and any subsequent push retry by the user will be rejected by NuGet.org as the package (with version) is already present on NuGet.org.

The primary functionality of push operation is to push the NuGet package to NuGet.org (or other package sources). If this function is successful, the CLI should return success.
The secondary functionality of pushing the symbols package automatically should result in a warning and not error. This will ensure enough traction on the symbols (auto) push failure but will not fail a build process (that also publishes the package).

@mishra14
Copy link
Contributor

@anangaur can you please assign a milestone to the issue based on the target for fixing this?

@anangaur
Copy link
Member Author

Still debating if we need to do this.

@rrelyea rrelyea added this to the Backlog milestone Oct 30, 2017
@rrelyea rrelyea added Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request labels Oct 30, 2017
@anangaur
Copy link
Member Author

anangaur commented Nov 9, 2017

No longer required as we plan to implement #6113

@anangaur anangaur closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Push Priority:1 High priority issues that must be resolved in the current sprint. Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

3 participants