Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push with --no-symbols should also not push symbols.nupkg #5442

Open
CoskunSunali opened this issue Jun 18, 2017 · 1 comment
Open

Push with --no-symbols should also not push symbols.nupkg #5442

CoskunSunali opened this issue Jun 18, 2017 · 1 comment
Labels
Area:Logging Category:Quality Week Issues that should be considered for quality week Functionality:Push Priority:2 Issues for the current backlog. Product:dotnet.exe Type:DCR Design Change Request
Milestone

Comments

@CoskunSunali
Copy link

Details about Problem

The command dotnet nuget push works as expected but reports wrong output.

dotnet.exe --info:

.NET Command Line Tools (2.0.0-preview1-005977)

Product Information:
Version: 2.0.0-preview1-005977
Commit SHA-1 hash: 414cab8a0b

Runtime Environment:
OS Name: Windows
OS Version: 10.0.15063
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\2.0.0-preview1-005977\

Microsoft .NET Core Shared Framework Host

Version : 2.0.0-preview1-002111-00
Build : 1ff021936263d492539399688f46fd3827169983

Detailed repro steps so we can see the same problem

  1. Execute dotnet pack command with --include-symbols option.
  2. Execute dotnet nuget push command with --no-symbols option (symbol packages created with the dotnet pack command are being pushed to a symbol server rather than the package server).
  3. The following result is generated reading that symbol package is pushed (partially copied here)
info : Pushing xyz.0.1.0-alpha.symbols.nupkg to 'https://www.myget.org/F/FeedName/api/v2/package'...
info :   PUT https://www.myget.org/F/FeedName/api/v2/package/
info :   Created https://www.myget.org/F/FeedName/api/v2/package/ 335ms
info : Your package was pushed.
  1. The symbol packages are actually never pushed which is the correct behavior. It is just the information message display is wrong.
    ...
@mishra14 mishra14 added this to the Backlog milestone Dec 19, 2017
@donnie-msft donnie-msft changed the title dotnet nuget push --no-symbols reports symbol packages as pushed Push with --no-symbols should also not push symbols.nupkg Dec 13, 2019
@donnie-msft
Copy link
Contributor

donnie-msft commented Dec 13, 2019

@rrelyea Push does try to pushing symbols.nupkgs even with this switch. The switch only disables .snupkgs. Is this an issue or by design? If the latter, then maybe simply clarifying the docs/help messages would be helpful.

Repro'd with 5.5.0 preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Logging Category:Quality Week Issues that should be considered for quality week Functionality:Push Priority:2 Issues for the current backlog. Product:dotnet.exe Type:DCR Design Change Request
Projects
None yet
Development

No branches or pull requests

6 participants