CPM - Updating GlobalPackageReference adds PackageVersion and PackageReference references to .csproj

[lauraneto]

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS 17.9.4

Worked before?

No response

Impact

It's more difficult to complete my work

Repro Steps & Context

Reproduction steps

1. Add a GlobalPackageReference entry to the Directory.Packages.props file.
   Example:

<Project>
  ...
  <ItemGroup>
    <GlobalPackageReference Include="Roslynator.Analyzers" Version="4.11.0" />
  <ItemGroup>
</Project>

2. Update the Roslynator.Analyzers package to 4.12.0 through VS.
3. Verify that the following lines were unexpectedly added to the .csproj file

<Project>
  ...
  <ItemGroup>
    <PackageVersion Update="Roslynator.Analyzers" Version="4.12.0" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Update="Roslynator.Analyzers">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
  </ItemGroup>
</Project>

Workaround

As a workaround, instead of using GlobalPackageReference it's possible to simply use a PackageReference, which works correctly with the Visual Studio Package Management UI.
The problem with this workaround is that when trying to add nuget packages via the CLI, an error will be shown due to this check: https://github.com/NuGet/NuGet.Client/blob/5789cc8f9cf67f421000af06040b0f73aa9ae2d9/src/NuGet.Core/NuGet.CommandLine.XPlat/Utility/MSBuildAPIUtility.cs#L187-L192

Verbose Logs

No response

[Bertk]

Please fix this bug and make the Global Package References feature usable.

I see this bug very often and the cleanup of unwanted modifications is time consuming because not everybody checks the results of a Visual Studio Manage Nuget Packages for Solution ... operation.

@madskristensen Please recognize this bug.

[madskristensen]

@JonDouglas

[hakenr]

This is a major pain, making the GlobalPackageReference feature unusable for teams updating package references with the Visual Studio NuGet Package Manager.
Even when using the central <PackageVersion /> for those GlobalReferences, the <PackageReference /> (without version) still gets added to the individual .csproj files.