Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of arguments in logs for centralized package version (string Info_AddPkgCPM) #13155

Closed
ztl8702 opened this issue Jan 13, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#6071
Assignees
Labels
Area:RestoreCPM Central package management Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug

Comments

@ztl8702
Copy link

ztl8702 commented Jan 13, 2024

NuGet Product Used

dotnet.exe, NuGet.exe

Product Version

NuGet Command Line 6.8.0.122 (via dotnet CLI)

Worked before?

No response

Impact

It bothers me. A fix would be nice

Repro Steps & Context

The string template Info_AddPkgCPM in https://github.com/dotnet/dotnet/blob/002d01eeae9f40bc6d021971cac07501928de3fc/src/nuget-client/src/NuGet.Core/NuGet.CommandLine.XPlat/Strings.resx#L764-L767

Renders to:

info : PackageReference for package 'NAudio' added to '/some-project/src/Directory.Packages.props' and PackageVersion added to central package management file '/some-project/src/Web/UiComponents/Zezo.UiComponents.csproj'.

shouldn't it instead be:

info : PackageReference for package 'NAudio' added to '/some-project/src/Web/UiComponents/Zezo.UiComponents.csproj'  and PackageVersion added to central package management file '/some-project/src/Directory.Packages.props'.

The arguments {1} and {2} should be swapped.

Verbose Logs

No response

@jeffkl jeffkl added Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week Area:RestoreCPM Central package management and removed Triage:Untriaged labels Jan 16, 2024
@jeffkl
Copy link
Contributor

jeffkl commented Jan 16, 2024

Thank you for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:RestoreCPM Central package management Category:Quality Week Issues that should be considered for quality week Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants