Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Watermark TextBox font color is incorrect in Add Dialog of Package Source Mapping Options #12141

Closed
donnie-msft opened this issue Oct 8, 2022 · 2 comments · Fixed by NuGet/NuGet.Client#4856
Closed

[Bug]: Watermark TextBox font color is incorrect in Add Dialog of Package Source Mapping Options #12141

donnie-msft opened this issue Oct 8, 2022 · 2 comments · Fixed by NuGet/NuGet.Client#4856
Assignees
@donnie-msft
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Category:Quality Week Issues that should be considered for quality week Functionality:VisualStudioUI Package Manager UI et al Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Accessibility Type:Bug
Milestone
6.5

Comments

@donnie-msft
Copy link
Contributor

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS 17.5

Worked before?

N/A

Impact

It bothers me. A fix would be nice

Repro Steps & Context

The font being picked up for this Watermarked TextBox control is not the ideal contrast.
Need to figure out either a more appropriate Style, or override the Foreground with a new color token.

image

Verbose Logs

No response
@donnie-msft donnie-msft added Product:VS.Client Priority:2 Issues for the current backlog. Type:Bug Functionality:VisualStudioUI Package Manager UI et al Tenet:Accessibility Area:PackageSourceMapping Issues related to the package source mapping feature labels Oct 8, 2022
@donnie-msft donnie-msft self-assigned this Oct 8, 2022
@donnie-msft donnie-msft mentioned this issue Oct 8, 2022
Merged
6 tasks
@donnie-msft donnie-msft added Category:Quality Week Issues that should be considered for quality week Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed labels Oct 13, 2022
@donnie-msft
Copy link
Contributor Author

Blocked on: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1642653

@donnie-msft donnie-msft mentioned this issue Oct 14, 2022
Open
@donnie-msft donnie-msft removed the Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed label Oct 14, 2022
@donnie-msft
Copy link
Contributor Author

Unblocking this bug by copying styles from VS Platform.
Created separate bug #12163 to remove those copies, which is blocked on https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1642653.

@donnie-msft donnie-msft mentioned this issue Oct 14, 2022
Merged
8 tasks
@martinrrm martinrrm added this to the 6.5 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donnie-msft donnie-msft

Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Category:Quality Week Issues that should be considered for quality week Functionality:VisualStudioUI Package Manager UI et al Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Accessibility Type:Bug
Projects
None yet
Milestone
6.5
2 participants
@martinrrm @donnie-msft