New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSM policy routes applied on VIP modification #164

Closed

6 tasks done

LionelJouin opened this issue Feb 15, 2022 · 0 comments

Closed

6 tasks done

NSM policy routes applied on VIP modification #164

LionelJouin opened this issue Feb 15, 2022 · 0 comments

Assignees

Member

LionelJouin commented Feb 15, 2022 •

edited

Loading

The ambassador should set the policy route on VIP modifications. Currently, the ambassador is adding the VIP addresses to the loopback interface and creates the source routes itself:
https://github.com/Nordix/Meridio/blob/issue/135/pkg/ambassador/tap/conduit/conduit.go#L183

Now Meridio has been uplifted to NSM 1.2, the policy routes have been added to the NSM API:
https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connectioncontext.proto#L74

Tasks:

Call NSM Request on each SetVIPs call
- Set the IPContext.policies
- Set the IPContext.SrcIpAddrs
- Filter out the VIPs in GetIPs func
Remove unsed code
Remove ambassador privileges

LionelJouin self-assigned this

LionelJouin mentioned this issue

NSM connection (VIPs and routes) update in TAPA #178

Merged

LionelJouin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment