Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate cargo-hack in CI #168

Closed
Wodann opened this issue Aug 16, 2023 · 1 comment · Fixed by NomicFoundation/hardhat#4380
Closed

Integrate cargo-hack in CI #168

Wodann opened this issue Aug 16, 2023 · 1 comment · Fixed by NomicFoundation/hardhat#4380
Assignees
@agostbiro
Milestone
EDR v0.1.0

Comments

@Wodann
Copy link
Member

Wodann commented Aug 16, 2023 •
edited
Loading

The way cargo resolves dependencies prevents us to run cargo check with --no-default-features for all crates. To circumvent this, we need an alternative. See rust-lang/cargo#12470 for more details.

Definition of Done
Integrate cargo-hack into the CI and resolve potential compiler errors
@Wodann Wodann added this to EDR Aug 16, 2023
@Wodann Wodann converted this from a draft issue Aug 16, 2023
@Wodann Wodann self-assigned this Aug 16, 2023
@Wodann Wodann added this to the EDR v0.1.0 milestone Aug 16, 2023
@Wodann Wodann removed their assignment Aug 16, 2023
@agostbiro agostbiro self-assigned this Aug 29, 2023
@agostbiro agostbiro mentioned this issue Sep 12, 2023
Merged
@agostbiro agostbiro linked a pull request Sep 12, 2023 that will close this issue
ci: use cargo hack instead of cargo check NomicFoundation/hardhat#4380
Merged
@agostbiro
Copy link
Member

Done in NomicFoundation/hardhat#4380

@github-project-automation github-project-automation bot moved this from Todo to Done in EDR Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agostbiro agostbiro

Labels
None yet
Projects
EDR
Status: Done
Milestone
EDR v0.1.0
Development

Successfully merging a pull request may close this issue.

ci: use cargo hack instead of cargo check NomicFoundation/hardhat
2 participants
@agostbiro @Wodann