Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sensitive API_KEY information from code #32

Closed
Nodrex opened this issue Apr 12, 2022 · 0 comments · Fixed by #391
Closed

Remove sensitive API_KEY information from code #32

Nodrex opened this issue Apr 12, 2022 · 0 comments · Fixed by #391
Assignees
@Nodrex
Labels
Security Enhancement

Comments

@Nodrex
Copy link
Owner

Nodrex commented Apr 12, 2022 •
edited
Loading

this API_KEY should be in a separate file and be downloaded when building automatically or some other solution should be discussed
@Nodrex Nodrex self-assigned this Apr 12, 2022
@Nodrex Nodrex added Security Enhancement Discussion Needed solution requires discussion in team labels Apr 12, 2022
@Nodrex Nodrex closed this as completed Apr 23, 2022
@Nodrex Nodrex reopened this Jun 4, 2022
@Nodrex Nodrex moved this to To do in Testomania Jan 31, 2023
@Nodrex Nodrex linked a pull request May 18, 2023 that will close this issue
Converted api key from query param in to header #391
Merged
@Nodrex Nodrex moved this from To do to Code review in Testomania May 18, 2023
@Nodrex Nodrex removed the Discussion Needed solution requires discussion in team label May 18, 2023
@Nodrex Nodrex moved this from Code review to Done in Testomania May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nodrex Nodrex

Labels
Security Enhancement
Projects
Testomania
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Converted api key from query param in to header Nodrex/Testomania
1 participant
@Nodrex