fix(vue-cli): Remove unnecessary configuration for vue-cli

NodeSitecore · Sep 11, 2018 · fdc9f64 · fdc9f64
1 parent d910ede
commit fdc9f64
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 60 deletions.
diff --git a/packages/cli-plugin-fractal/config.js b/packages/cli-plugin-fractal/config.js
@@ -10,7 +10,7 @@ module.exports = config => {
       docsDir: '<rootDir>/fractal/docs',
       helpersDir: '<rootDir>/fractal/helpers',
       middlewaresDir: '<rootDir>/fractal/middlewares',
-      proxyPatterns: ['/Fonts/**', '/Images/**', '/Icons/**'],
+      proxyPatterns: ['/fonts/**', '/images/**', '/icons/**', '/medias/**', '/public/**'],
       ...(config.get('fractal') || {})
     })
   );
@@ -31,7 +31,7 @@ module.exports = config => {
 
       vendors.push(`/vendors.${name}.js`);
       bundles.push(`/${name}.js`);
-      styles.push(`/${name}.css`);
+      styles.push(`css/${name}.css`);
 
       cleanGlob.push(`${name}.**`);
     });

diff --git a/packages/cli-plugin-vue/src/webpack/assets.js b/packages/cli-plugin-vue/src/webpack/assets.js
@@ -1,60 +1,9 @@
 const getAssetPath = require('@vue/cli-service/lib/util/getAssetPath');
 
 module.exports = function buildWebpackAssets(config, webpackConfig, vueConfig) {
-  const inlineLimit = 10000;
-
   webpackConfig
     .mode('production')
     .devtool('source-map')
     .output.filename(getAssetPath(vueConfig, '[name].js'))
     .chunkFilename(getAssetPath(vueConfig, '[name].js'));
-
-  webpackConfig.module
-    .rule('images')
-    .test(/\.(png|jpe?g|gif)(\?.*)?$/)
-    .use('url-loader')
-    .loader('url-loader')
-    .options({
-      limit: inlineLimit,
-      name: 'Images/[name].[hash:8].[ext]'
-    });
-
-  webpackConfig.module
-    .rule('svg')
-    .test(/\.(svg)(\?.*)?$/)
-    .use('file-loader')
-    .loader('file-loader')
-    .options({
-      name: 'Icons/[name].[hash:8].[ext]'
-    });
-
-  webpackConfig.module
-    .rule('media')
-    .test(/\.(mp4|webm|ogg|mp3|wav|flac|aac)(\?.*)?$/)
-    .use('url-loader')
-    .loader('url-loader')
-    .options({
-      limit: inlineLimit,
-      name: 'Medias/[name].[hash:8].[ext]'
-    });
-
-  webpackConfig.module
-    .rule('fonts')
-    .test(/\.(woff2?|eot|ttf|otf)(\?.*)?$/i)
-    .use('url-loader')
-    .loader('url-loader')
-    .options({
-      limit: inlineLimit,
-      name: 'Fonts/[name].[hash:8].[ext]'
-    });
-
-  if (webpackConfig.plugins.has('extract-css')) {
-    webpackConfig.plugin('extract-css').tap(args =>
-      args.map(item => ({
-        ...item,
-        filename: getAssetPath(webpackConfig, '[name].css'),
-        chunkFilename: getAssetPath(webpackConfig, '[name].css')
-      }))
-    );
-  }
 };
diff --git a/packages/cli-plugin-vue/src/webpack/build.js b/packages/cli-plugin-vue/src/webpack/build.js
@@ -45,16 +45,16 @@ module.exports = (config, baseVueConfig) => {
     },
 
     chainWebpack(webpackConfig) {
-      const isProd = process.env.NODE_ENV === 'production';
+      // const isProd = process.env.NODE_ENV === 'production';
       // Reset configuration
       resetWebpackConfig(webpackConfig);
 
-      if (isProd) {
-        webpackConfig
-          .devtool('source-map')
-          .output.filename('[name].js')
-          .chunkFilename('[id].js');
-      }
+      // if (isProd) {
+      //   webpackConfig
+      //     .devtool('source-map')
+      //     .output.filename('[name].js')
+      //     .chunkFilename('[id].js');
+      // }
 
       buildWebpackAlias(config, webpackConfig);
       buildWebpackEntries(config, webpackConfig, vueConfig);