Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow npm strategy to work with pnpm #57

Closed
antoine-coulon opened this issue Oct 23, 2022 · 2 comments
Closed

Allow npm strategy to work with pnpm #57

antoine-coulon opened this issue Oct 23, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@antoine-coulon
Copy link
Member

antoine-coulon commented Oct 23, 2022

Currently, the npm strategy only works for package-lock.json and npm-shrinkwrap.json lock files.

We could actually extend that to pnpm-lock.yaml using the npm strategy using programmatically the library provided by the pnpm organization which uses the same vulnerability registry.

It would allow us to enhance the compatibility of the npm strategy (pnpm + npm would be both supported).

@antoine-coulon antoine-coulon changed the title Allow npm strategy to work with pnpm lock files Allow npm strategy to work with pnpm Oct 23, 2022
@antoine-coulon antoine-coulon added good first issue Good for newcomers enhancement New feature or request labels Oct 23, 2022
@DGouron
Copy link

DGouron commented Jan 4, 2023

Hi ! Can i work on this issue or someone is already on it ? :)

@antoine-coulon
Copy link
Member Author

Hello ! As far as I know, nobody currently works on it, so feel free to take the subject :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants