fix: fixed spacing issues on mobile and large view and fixed text siz… #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Njong392
requested changes
Jan 11, 2023
src/components/form.jsx
Outdated
| <> | ||
| <div className="mt-2 text-purple font-bold text-xl ml-2 dark:text-deeppurple"> | ||
| <div className="bg-ash shadow-lg border-2 border-deeppurple py-2 pl-2 rounded-lg mt-4"> | ||
| <div className="mt-1 text-purple font-bold text-xl ml-2 dark:text-deeppurple"> |
There was a problem hiding this comment.
In light mode the definition is in text-deeppurple, but in dark mode it's back to text-purple. Since in dark mode the abbrevaition region is surrounded by bg-ash, the text should remain text-deepurple. What do u think?
Suggested change
| <div className="mt-1 text-purple font-bold text-xl ml-2 dark:text-deeppurple"> | |
| <div className="mt-1 font-bold text-xl ml-2 text-deeppurple"> |
There was a problem hiding this comment.
opps sorry about that i will fix that and re-push
There was a problem hiding this comment.
i've corrected this
|
Sorry, but I had to ask. How does this PR close #188 ? |
sorry about this that issue was wrongly tagged |
Njong392
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e issues
fixes #174
fixes #206
Closes #
What new changes did you make? Tick all applicable boxes
Describe the new changes you added.
i reduced and added some padding && margin to the appriopriate place
Share a screenshot of new changes
i have corrected this