Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting has invalid type, expected string[] #32

Open
necmettin opened this issue Jun 9, 2020 · 1 comment
Open

setting has invalid type, expected string[] #32

necmettin opened this issue Jun 9, 2020 · 1 comment

Comments

@necmettin
Copy link

I am a Mac user.

In VSCode settings ui, Resmon>Disk: Drives setting reports Setting has an invalid type, expected "String[]". Fix in JSON.

When you try to edit "resmon.disk.drives" in user settings json, these values do not work:

  • null
  • "/dev/disk1s5"
  • "/Volumes/mbp"
  • ["/dev/disk1s5"]
  • ["/Volumes/mbp"]
  • "['/Volumes/mbp']"

README notes "C:" for Windows and '/dev/sda1' for Linux. No examples for Mac. Single quotes are not accepted in settings JSON at all.

Although I don't want to see disk space in the status bar, what is the correct value to enter for resmon.disk.drives ?

@bersbersbers
Copy link

This has been fixed in 63cc9d7, but it seem that did not make it into the store version. The previous version had an incorrect type in package.json:

resmon/package.json

Lines 66 to 69 in e3cf473

"resmon.disk.drives": {
"type": "string[]",
"default": []
},

I tried modifying package.json along the lines of 63cc9d7, which fixed the JSON error but did not enable the functionality.

By the way, I think the expected notation is

"resmon.disk.drives": [
        "/home/bers",
        "/data/bers",
    ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants