wildmidi: Enable on Darwin & refactor config, gst-plugins-bad: enable wildmidi on Darwin #242621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable on Darwin (uses OpenAL framework there)
- refactor default config
- use WriteTextFile and symlink instead of echoing together
- set WILDMIDI_CFG cmake variable instead of patching its default value
- correct config location
- default (and now explicitly-set) location is actually /etc/wildmidi/wildmidi.cfg
12 tasks
bjornfor
approved these changes
Jul 10, 2023
OPNA2608
changed the title
|
@GrahamcOfBorg eval |
lilyinstarlight
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Seems to build fine for me on aarch64-darwin and x86_64-linux
I'll approve the gst-plugins-bad changes and given @bjornfor already approved the wildmidi changes as maintainer, I'll go ahead and merge this
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
wildmidi:
WriteTextFileand symlink instead of echoing togetherWILDMIDI_CFGcmake variable instead of patching its default valuegst-plugins-bad:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)