Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how gtk themes and propagatedUserEnvPkgs work #73967

Open
nh2 opened this issue Nov 23, 2019 · 7 comments
Open

Document how gtk themes and propagatedUserEnvPkgs work #73967

nh2 opened this issue Nov 23, 2019 · 7 comments
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: xfce The Xfce Desktop Environment 9.needs: documentation
Milestone

Comments

@nh2
Copy link
Contributor

nh2 commented Nov 23, 2019

Issue description

One of the things that confuses me on NixOS desktop is that I can make gtk themes available to XFCE using:

environment.systemPackages = with pkgs; [
  gnome-themes-standard
];

This doesn't seem to be documented anywhere, and I also don't understand how it works.

Does propagatedUserEnvPkgs play a role here? That functionality, too, seems completely undocumented.

Both these things should be described in the nixpkgs or NixOS manual.

@veprbl veprbl added 6.topic: xfce The Xfce Desktop Environment 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 24, 2019
@FRidh FRidh added this to the 20.03 milestone Nov 24, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 24, 2019

Do you mean propagation of the theme engines?

Because in this example gnome-themes-extra doesn't do any kind of propagation of user environment packages. Themes work because they get linked at /run/current-system/sw/share/themes and end up in XDG_DATA_DIRS. Expected behavior of gtk. Otherwise some program is wrapped with a gtk theme in the same manner.

And we do document this in the nixpkgs manual

What's probably missing is stuff like this in the NixOS manual.
(i.e the intended consumer of the information in the nixpkgs manual is people packaging gtk things for nixpkgs)

@worldofpeace
Copy link
Contributor

Having something like #71079 would make the theming story for NixOS make a little more declarative sense. Though there's an issue with it being system-wide.
My thoughts at #70276 (comment) for a better user story.

@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@stale
Copy link

stale bot commented Aug 4, 2020

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 4, 2020
@nh2
Copy link
Contributor Author

nh2 commented Aug 4, 2020

still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 4, 2020
@FRidh FRidh modified the milestones: 20.09, 21.03 Dec 20, 2020
@stale
Copy link

stale bot commented Jun 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2021
@Artturin Artturin modified the milestones: 21.05, 23.05 Dec 31, 2022
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Dec 31, 2022
@RaitoBezarius RaitoBezarius modified the milestones: 23.05, 23.11 May 31, 2023
@TLATER
Copy link
Contributor

TLATER commented Jun 10, 2023

Is there any reason nobody has touched this since #71079 was reverted? I've been using home-manager for this, but surely a system-wide option would make sense?

@jtojnar
Copy link
Member

jtojnar commented Jun 10, 2023

@TLATER Probably because no-one interested in this found time to do this yet.

If someone wants to resurrect #71079, it should probably be based on RFC 42-style settings and modules for different GTK versions should be decoupled, as they are completely separate things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: xfce The Xfce Desktop Environment 9.needs: documentation
Projects
Status: Accepting PRs
Development

No branches or pull requests

9 participants