Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: nodejs_20 #326150

Closed
agj opened this issue Jul 10, 2024 · 5 comments
Closed

Build failure: nodejs_20 #326150

agj opened this issue Jul 10, 2024 · 5 comments
Labels

Comments

@agj
Copy link

agj commented Jul 10, 2024

Steps To Reproduce

I ran nix develop --print-build-logs with the following flake.nix:

{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable";
  };

  outputs = {
    self,
    nixpkgs,
  }: let
    pkgs = import nixpkgs {system = "x86_64-darwin";};
  in {
    devShell."x86_64-darwin" = pkgs.mkShell {
      buildInputs = with pkgs; [
        nodejs_20
      ];
    };
  };
}

Build log

Console output.

Additional context

  • I'm on macOS Monterey (12.7.5).
  • Once the __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ warnings start showing, it starts looping and the process never exits.

Notify maintainers

@cillianderoiste @aduh95

Thank you, friends, for your work and help. 🙏

Metadata

 - system: `"x86_64-darwin"`
 - host os: `Darwin 21.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.2`
 - channels(Ale): `"nixpkgs"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Add a 👍 reaction to issues you find important.

@eclairevoyant eclairevoyant added 6.topic: darwin Running or building packages on Darwin 6.topic: nodejs labels Jul 10, 2024
@tie
Copy link
Member

tie commented Jul 19, 2024

Once the __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ warnings start showing, it starts looping and the process never exits.

Looking at the logs you’ve provided (https://gist.githubusercontent.com/agj/7282fda50c4d94751be7b47fd2bf7a9c/raw/590bc3f473eacc586639b1b526d472bdd99cb01b/build-nodejs-20-nix-error.log), I don’t see any particular spot where it starts looping (but it does print the warning for many different files being compiled) until an ongoing build is manually interrupted 🧐

@aduh95
Copy link
Contributor

aduh95 commented Jul 19, 2024

#327653 is fixing the issue for me on aarch64 Sonoma (14.5)

@tie tie mentioned this issue Jul 19, 2024
16 tasks
@tie
Copy link
Member

tie commented Jul 19, 2024

Yeah, the PR above refactors Node.js package build process (and also makes it much faster). I’ve added this issue to the list that the PR fixes to keep track of it.

@agj
Copy link
Author

agj commented Jul 21, 2024

@tie The first time, when I noticed the problem, I let it run for a few hours but it was going nowhere. After that, while writing this issue, I let it run only for a bit and saved that log. Might be that it wasn't in fact looping, but it was at least taking much longer than it should.

That said, the issue is fixed now for me, so I'm closing this. Also, I tried earlier building from the above PR's branch, and it attempted to build the world for 14 hours and then failed some tests and aborted… If @tie you're interested, I can add more info in the PR.

@agj agj closed this as completed Jul 21, 2024
@tie
Copy link
Member

tie commented Jul 23, 2024

Also, I tried earlier building from the above PR's branch, and it attempted to build the world for 14 hours and then failed some tests and aborted… If @tie you're interested, I can add more info in the PR.

@agj, yes, thanks, I’d appreciate your feedback on that (especially if the failing tests are in nodejs package).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants